doc: change smartos support type to experimental #56220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
anonrig
commented
Dec 11, 2024
anonrig
force-pushed
the
yagiz/lower-smartos-experimental
branch
from
fc1cf65 to
9e99d90
Compare
|
I've replied to nodejs/TSC#1663. Given my comments there, I think it's premature (at best) to demote SmartOS. I vote to close this PR without merging. |
bahamat
suggested changes
Dec 11, 2024
mcollina
added
the
tsc-agenda
|
Are there other cases of tier 2 platforms that we don't release binaries for? |
mcollina
requested changes
Dec 18, 2024
I disagree. |
|
I opened nodejs/TSC#1666 as an alternative - IMO, we should change how we treat tier 2 platforms (i.e. don't insist on keeping all tests green in every PR on them) to make it sustainable. Otherwise there's effectively no difference between tier 1 and tier 2, and basically only tier 1 and experimental, which would lead to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for nodejs/TSC#1663
cc @nodejs/build @nodejs/tsc @nodejs/platform-smartos