test: remove unnecessary skipIf32Bits calls

nodejs · Feb 9, 2025 · db365dc · db365dc
1 parent a2aa6ca
commit db365dc
Show file tree

Hide file tree

Showing 14 changed files with 1 addition and 37 deletions.
diff --git a/test/common/README.md b/test/common/README.md
@@ -458,11 +458,6 @@ at `tools/eslint/node_modules/eslint`
 Skip the rest of the tests in the current file when the Inspector
 was disabled at compile time.
 
-### `skipIf32Bits()`
-
-Skip the rest of the tests in the current file when the Node.js executable
-was compiled with a pointer size smaller than 64 bits.
-
 ## ArrayStream module
 
 The `ArrayStream` module provides a simple `Stream` that pushes elements from

diff --git a/test/common/index.js b/test/common/index.js
@@ -32,8 +32,6 @@ const { inspect, getCallSites } = require('util');
 const { isMainThread } = require('worker_threads');
 
 const tmpdir = require('./tmpdir');
-const bits = ['arm64', 'loong64', 'mips', 'mipsel', 'ppc64', 'riscv64', 's390x', 'x64']
-  .includes(process.arch) ? 64 : 32;
 const hasIntl = !!process.config.variables.v8_enable_i18n_support;
 
 const {
@@ -676,12 +674,6 @@ function skipIfInspectorDisabled() {
   }
 }
 
-function skipIf32Bits() {
-  if (bits < 64) {
-    skip('The tested feature is not available in 32bit builds');
-  }
-}
-
 function getArrayBufferViews(buf) {
   const { buffer, byteOffset, byteLength } = buf;
 
@@ -897,7 +889,6 @@ const common = {
   requireNoPackageJSONAbove,
   runWithInvalidFD,
   skip,
-  skipIf32Bits,
   skipIfEslintMissing,
   skipIfInspectorDisabled,
   spawnPromisified,

diff --git a/test/common/index.mjs b/test/common/index.mjs
@@ -41,7 +41,6 @@ const {
   printSkipMessage,
   runWithInvalidFD,
   skip,
-  skipIf32Bits,
   skipIfEslintMissing,
   skipIfInspectorDisabled,
   spawnPromisified,
@@ -89,7 +88,6 @@ export {
   printSkipMessage,
   runWithInvalidFD,
   skip,
-  skipIf32Bits,
   skipIfEslintMissing,
   skipIfInspectorDisabled,
   spawnPromisified,

diff --git a/test/parallel/test-buffer-tostring-range.js b/test/parallel/test-buffer-tostring-range.js
@@ -1,6 +1,6 @@
 'use strict';
 
-const common = require('../common');
+require('../common');
 const assert = require('assert');
 
 const rangeBuffer = Buffer.from('abc');
@@ -100,9 +100,6 @@ assert.throws(() => {
 });
 
 // Must not throw when start and end are within kMaxLength
-// Cannot test on 32bit machine as we are testing the case
-// when start and end are above the threshold
-common.skipIf32Bits();
 const threshold = 0xFFFFFFFF;
 const largeBuffer = Buffer.alloc(threshold + 20);
 largeBuffer.toString('utf8', threshold, threshold + 20);
diff --git a/test/parallel/test-fs-write-buffer-large.js b/test/parallel/test-fs-write-buffer-large.js
@@ -6,10 +6,6 @@ const fs = require('fs');
 const tmpdir = require('../common/tmpdir');
 tmpdir.refresh();
 
-// fs.write with length > INT32_MAX
-
-common.skipIf32Bits();
-
 let buf;
 try {
   buf = Buffer.allocUnsafe(0x7FFFFFFF + 1);

diff --git a/test/parallel/test-inspect-async-hook-setup-at-inspect.js b/test/parallel/test-inspect-async-hook-setup-at-inspect.js
@@ -1,7 +1,6 @@
 'use strict';
 const common = require('../common');
 common.skipIfInspectorDisabled();
-common.skipIf32Bits();
 const { NodeInstance } = require('../common/inspector-helper.js');
 const assert = require('assert');
 

diff --git a/test/parallel/test-inspector-async-call-stack-abort.js b/test/parallel/test-inspector-async-call-stack-abort.js
@@ -3,7 +3,6 @@
 'use strict';
 const common = require('../common');
 common.skipIfInspectorDisabled();
-common.skipIf32Bits();
 
 const { strictEqual } = require('assert');
 const eyecatcher = 'nou, houdoe he?';

diff --git a/test/parallel/test-inspector-async-call-stack.js b/test/parallel/test-inspector-async-call-stack.js
@@ -2,7 +2,6 @@
 'use strict';
 const common = require('../common');
 common.skipIfInspectorDisabled();
-common.skipIf32Bits();
 
 const assert = require('assert');
 const { inspect } = require('util');

diff --git a/test/parallel/test-inspector-async-hook-setup-at-inspect-brk.js b/test/parallel/test-inspector-async-hook-setup-at-inspect-brk.js
@@ -1,7 +1,6 @@
 'use strict';
 const common = require('../common');
 common.skipIfInspectorDisabled();
-common.skipIf32Bits();
 const { NodeInstance } = require('../common/inspector-helper.js');
 const assert = require('assert');
 

diff --git a/test/parallel/test-inspector-async-hook-setup-at-signal.js b/test/parallel/test-inspector-async-hook-setup-at-signal.js
@@ -2,7 +2,6 @@
 'use strict';
 const common = require('../common');
 common.skipIfInspectorDisabled();
-common.skipIf32Bits();
 const { NodeInstance } = require('../common/inspector-helper.js');
 const assert = require('assert');
 

diff --git a/test/parallel/test-inspector-async-stack-traces-promise-then.js b/test/parallel/test-inspector-async-stack-traces-promise-then.js
@@ -1,7 +1,6 @@
 'use strict';
 const common = require('../common');
 common.skipIfInspectorDisabled();
-common.skipIf32Bits();
 const { NodeInstance } = require('../common/inspector-helper');
 const assert = require('assert');
 

diff --git a/test/parallel/test-inspector-async-stack-traces-set-interval.js b/test/parallel/test-inspector-async-stack-traces-set-interval.js
@@ -1,7 +1,6 @@
 'use strict';
 const common = require('../common');
 common.skipIfInspectorDisabled();
-common.skipIf32Bits();
 const { NodeInstance } = require('../common/inspector-helper');
 const assert = require('assert');
 

diff --git a/test/pummel/test-blob-slice-with-large-size.js b/test/pummel/test-blob-slice-with-large-size.js
@@ -1,9 +1,6 @@
 'use strict';
 const common = require('../common');
 
-// Buffer with size > INT32_MAX
-common.skipIf32Bits();
-
 const assert = require('assert');
 
 const size = 2 ** 31;

diff --git a/test/pummel/test-string-decoder-large-buffer.js b/test/pummel/test-string-decoder-large-buffer.js
@@ -1,9 +1,6 @@
 'use strict';
 const common = require('../common');
 
-// Buffer with size > INT32_MAX
-common.skipIf32Bits();
-
 const assert = require('assert');
 const { StringDecoder } = require('node:string_decoder');
 const kStringMaxLength = require('buffer').constants.MAX_STRING_LENGTH;