test: allow especial characters in snapshot keys

Fixes: #56836
nodejs · Feb 12, 2025 · b91c14b · b91c14b
1 parent 1671921
commit b91c14b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/internal/test_runner/snapshot.js b/lib/internal/test_runner/snapshot.js
@@ -77,7 +77,7 @@ class SnapshotFile {
   }
 
   setSnapshot(id, value) {
-    this.snapshots[templateEscape(id)] = value;
+    this.snapshots[keyEscape(id)] = value;
   }
 
   nextId(name) {
@@ -290,6 +290,13 @@ function validateFunctionArray(fns, name) {
   }
 }
 
+function keyEscape(str) {
+  let result = JSONStringify(str, null, 2).slice(1, -1);
+  result = StringPrototypeReplaceAll(result, '`', '\\`');
+  result = StringPrototypeReplaceAll(result, '${', '\\${');
+  return result;
+}
+
 function templateEscape(str) {
   let result = String(str);
   result = StringPrototypeReplaceAll(result, '\\', '\\\\');

diff --git a/test/parallel/test-runner-snapshot-tests.js b/test/parallel/test-runner-snapshot-tests.js
@@ -158,6 +158,8 @@ suite('SnapshotManager', () => {
 
     file.setSnapshot('foo`${x}` 1', 'test');
     t.assert.strictEqual(file.getSnapshot('foo\\`\\${x}\\` 1'), 'test');
+    file.setSnapshot('\r 1', 'test');
+    t.assert.strictEqual(file.getSnapshot('\\r 1'), 'test');
   });
 
   test('throws if snapshot file cannot be resolved', (t) => {