Skip to content

get函数支持配置超时时间 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

imseon
Copy link

@imseon imseon commented Feb 19, 2016

No description provided.

@calidion
Copy link
Member

感谢提交。
请添加测试用例,并调整travis ci配置通过测试。
谢谢。

@imseon
Copy link
Author

imseon commented Feb 19, 2016

我看了报错,应该是缺少环境变量配置,需要配置APP_ID和APP_SECRET,这个是不能公开的信息,我想问下之前是怎么做的?我的改动应该不会影响ci的检测

@calidion
Copy link
Member

@imseon 请注册下travis-ci 添加必要的参数进行测试。谢谢。

} else {
cb(true, {message: body});
}
settings.get(app.id,'request',function (requestData) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app.id,'request',function (
=>
app.id, 'request', function(

@imseon
Copy link
Author

imseon commented Mar 24, 2016

travis-ci build 通过了

@calidion
Copy link
Member

@imseon
这个PR跟当前代码已经不兼容。
你可以fork一个最新代码再修改。
变化应该比较大。
你看一下在方便的地方添加相应的参数。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants