This repository was archived by the owner on Feb 3, 2023. It is now read-only.
Open
Conversation
Collaborator
|
If we're killing githooks in the makefile I'd like to remove the actual scripts as well. I'll spend some time this weekend doing some minor manual regression testing on this PR. Thanks @paulcpederson! |
Contributor
Author
|
@Lochlan do you want me to add that to this pr? I don't think we're using them anymore since we moved to precommit |
Contributor
|
hey boys, what's the scoop? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build for this will fail as the coverage reporter is still broken, but
make lintmake testandmake browser-testall run fine and exit successfully./cc @Lochlan @cdaringe