fix: should got undici:client:sendHeaders message on H2 #553
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request enhance the Changes
Assessment against linked issues
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
src/HttpClient.ts(1 hunks)src/utils.ts(1 hunks)test/diagnostics_channel.test.ts(2 hunks)
🧰 Additional context used
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 22)
test/diagnostics_channel.test.ts
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:143:9
❯ writeH1 node:internal/deps/undici/undici:6443:30
❯ Object.write node:internal/deps/undici/undici:6278:18
❯ _resume node:internal/deps/undici/undici:7945:54
❯ resume node:internal/deps/undici/undici:7881:7
❯ Client. node:internal/deps/undici/undici:7666:35
❯ connect node:internal/deps/undici/undici:7868:22
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:143:9
❯ Request.onComplete node:internal/deps/undici/undici:2077:29
❯ Parser.onMessageComplete node:internal/deps/undici/undici:6169:17
❯ wasm_on_message_complete node:internal/deps/undici/undici:5809:34
❯ null. wasm:/wasm/0002f80e:1:26723
❯ Parser.execute node:internal/deps/undici/undici:5922:26
❯ Parser.readMore node:internal/deps/undici/undici:5901:16
❯ Socket. node:internal/deps/undici/undici:6229:18
❯ Socket.emit node:events:518:28
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:143:9
❯ writeH1 node:internal/deps/undici/undici:6443:30
❯ Object.write node:internal/deps/undici/undici:6278:18
❯ _resume node:internal/deps/undici/undici:7945:54
❯ resume node:internal/deps/undici/undici:7881:7
❯ Client. node:internal/deps/undici/undici:7666:35
❯ connect node:internal/deps/undici/undici:7868:22
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:143:9
❯ Request.onComplete node:internal/deps/undici/undici:2077:29
❯ Parser.onMessageComplete node:internal/deps/undici/undici:6169:17
❯ wasm_on_message_complete node:internal/deps/undici/undici:5809:34
❯ null. wasm:/wasm/0002f80e:1:6425
❯ Parser.execute node:internal/deps/undici/undici:5922:26
❯ Parser.readMore node:internal/deps/undici/undici:5901:16
❯ Socket. node:internal/deps/undici/undici:6229:18
❯ Socket.emit node:events:518:28
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:143:9
❯ writeH1 node:internal/deps/undici/undici:6443:30
❯ Object.write node:internal/deps/undici/undici:6278:18
❯ _resume node:internal/deps/undici/undici:7945:54
❯ resume node:internal/deps/undici/undici:7881:7
❯ Client. node:internal/deps/undici/undici:7666:35
❯ Client.[dispatch] node:internal/deps/undici/undici:7707:24
❯ Client.Intercept node:internal/deps/undici/undici:7435:20
❯ Client.dispatch node:internal/deps/undici/undici:588:44
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:143:9
❯ Request.onComplete node:internal/deps/undici/undici:2077:29
❯ Parser.onMessageComplete node:internal/deps/undici/undici:6169:17
❯ wasm_on_message_complete node:internal/deps/undici/undici:5809:34
❯ null. wasm:/wasm/0002f80e:1:6425
❯ Parser.execute node:internal/deps/undici/undici:5922:26
❯ Parser.readMore node:internal/deps/undici/undici:5901:16
❯ Socket. node:internal/deps/undici/undici:6229:18
❯ Socket.emit node:events:518:28
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:143:9
❯ writeH1 node:internal/deps/undici/undici:6443:30
❯ Object.write node:internal/deps/undici/undici:6278:18
❯ _resume node:internal/deps/undici/undici:7945:54
❯ resume node:internal/deps/undici/undici:7881:7
❯ Client. node:internal/deps/undici/undici:7666:35
❯ Client.[dispatch] node:internal/deps/undici/undici:7707:24
❯ Client.Intercept node:internal/deps/undici/undici:7435:20
❯ Client.dispatch node:internal/deps/undici/undici:588:44
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:143:9
❯ Request.onComplete node:internal/deps/undici/undici:2077:29
❯ Parser.onMessageComplete node:internal/deps/undici/undici:6169:17
❯ wasm_on_message_complete node:internal/deps/undici/undici:5809:34
❯ null. wasm:/wasm/0002f80e:1:6425
❯ Parser.execute node:internal/deps/undici/undici:5922:26
❯ Parser.readMore node:internal/deps/undici/undici:5901:16
❯ Socket. node:internal/deps/undici/undici:6229:18
❯ Socket.emit node:events:518:28
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:143:9
❯ writeH1 node:internal/deps/undici/undici:6443:30
❯ Object.write node:internal/deps/undici/undici:6278:18
❯ _resume node:internal/deps/undici/undici:7945:54
❯ resume node:internal/deps/undici/undici:7881:7
❯ Client. node:internal/deps/undici/undici:7666:35
❯ Client.[dispatch] node:internal/deps/undici/undici:7707:24
❯ Client.Intercept node:internal/deps/undici/undici:7435:20
❯ Client.dispatch node:internal/deps/undici/undici:588:44
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:143:9
❯ Request.onComplete node:internal/deps/undici/undici:2077:29
❯ Parser.onMessageComplete node:internal/deps/undici/undici:6169:17
❯ wasm_on_message_complete node:internal/deps/undici/undici:5809:34
❯ null. wasm:/wasm/0002f80e:1:6425
❯ Parser.execute node:internal/deps/undici/undici:5922:26
❯ Parser.readMore node:internal/deps/undici/undici:5901:16
❯ Socket. node:internal/deps/undici/undici:6229:18
❯ Socket.emit node:events:518:28
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 23)
test/diagnostics_channel.test.ts
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:150:9
❯ writeH1 node:internal/deps/undici/undici:6492:30
❯ Object.write node:internal/deps/undici/undici:6327:18
❯ _resume node:internal/deps/undici/undici:8027:54
❯ resume node:internal/deps/undici/undici:7963:7
❯ Client. node:internal/deps/undici/undici:7750:35
❯ connect node:internal/deps/undici/undici:7950:22
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:150:9
❯ Request.onComplete node:internal/deps/undici/undici:2077:29
❯ Parser.onMessageComplete node:internal/deps/undici/undici:6218:17
❯ wasm_on_message_complete node:internal/deps/undici/undici:5858:34
❯ null. wasm:/wasm/0002f80e:1:26723
❯ Parser.execute node:internal/deps/undici/undici:5971:26
❯ Parser.readMore node:internal/deps/undici/undici:5950:16
❯ Socket. node:internal/deps/undici/undici:6278:18
❯ Socket.emit node:events:513:28
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:150:9
❯ writeH1 node:internal/deps/undici/undici:6492:30
❯ Object.write node:internal/deps/undici/undici:6327:18
❯ _resume node:internal/deps/undici/undici:8027:54
❯ resume node:internal/deps/undici/undici:7963:7
❯ Client. node:internal/deps/undici/undici:7750:35
❯ connect node:internal/deps/undici/undici:7950:22
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:150:9
❯ Request.onComplete node:internal/deps/undici/undici:2077:29
❯ Parser.onMessageComplete node:internal/deps/undici/undici:6218:17
❯ wasm_on_message_complete node:internal/deps/undici/undici:5858:34
❯ null. wasm:/wasm/0002f80e:1:6425
❯ Parser.execute node:internal/deps/undici/undici:5971:26
❯ Parser.readMore node:internal/deps/undici/undici:5950:16
❯ Socket. node:internal/deps/undici/undici:6278:18
❯ Socket.emit node:events:513:28
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:150:9
❯ writeH1 node:internal/deps/undici/undici:6492:30
❯ Object.write node:internal/deps/undici/undici:6327:18
❯ _resume node:internal/deps/undici/undici:8027:54
❯ resume node:internal/deps/undici/undici:7963:7
❯ Client. node:internal/deps/undici/undici:7750:35
❯ Client.[dispatch] node:internal/deps/undici/undici:7791:24
❯ Client.Intercept node:internal/deps/undici/undici:7517:20
❯ Client.dispatch node:internal/deps/undici/undici:588:44
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:150:9
❯ Request.onComplete node:internal/deps/undici/undici:2077:29
❯ Parser.onMessageComplete node:internal/deps/undici/undici:6218:17
❯ wasm_on_message_complete node:internal/deps/undici/undici:5858:34
❯ null. wasm:/wasm/0002f80e:1:6425
❯ Parser.execute node:internal/deps/undici/undici:5971:26
❯ Parser.readMore node:internal/deps/undici/undici:5950:16
❯ Socket. node:internal/deps/undici/undici:6278:18
❯ Socket.emit node:events:513:28
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:150:9
❯ writeH1 node:internal/deps/undici/undici:6492:30
❯ Object.write node:internal/deps/undici/undici:6327:18
❯ _resume node:internal/deps/undici/undici:8027:54
❯ resume node:internal/deps/undici/undici:7963:7
❯ Client. node:internal/deps/undici/undici:7750:35
❯ Client.[dispatch] node:internal/deps/undici/undici:7791:24
❯ Client.Intercept node:internal/deps/undici/undici:7517:20
❯ Client.dispatch node:internal/deps/undici/undici:588:44
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:150:9
❯ Request.onComplete node:internal/deps/undici/undici:2077:29
❯ Parser.onMessageComplete node:internal/deps/undici/undici:6218:17
❯ wasm_on_message_complete node:internal/deps/undici/undici:5858:34
❯ null. wasm:/wasm/0002f80e:1:6425
❯ Parser.execute node:internal/deps/undici/undici:5971:26
❯ Parser.readMore node:internal/deps/undici/undici:5950:16
❯ Socket. node:internal/deps/undici/undici:6278:18
❯ Socket.emit node:events:513:28
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:150:9
❯ writeH1 node:internal/deps/undici/undici:6492:30
❯ Object.write node:internal/deps/undici/undici:6327:18
❯ _resume node:internal/deps/undici/undici:8027:54
❯ resume node:internal/deps/undici/undici:7963:7
❯ Client. node:internal/deps/undici/undici:7750:35
❯ Client.[dispatch] node:internal/deps/undici/undici:7791:24
❯ Client.Intercept node:internal/deps/undici/undici:7517:20
❯ Client.dispatch node:internal/deps/undici/undici:588:44
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
[failure] 180-180: Unhandled error
TypeError: Cannot read properties of undefined (reading 'opaque')
❯ onMessage test/diagnostics_channel.test.ts:180:28
❯ Channel.publish node:diagnostics_channel:150:9
❯ Request.onComplete node:internal/deps/undici/undici:2077:29
❯ Parser.onMessageComplete node:internal/deps/undici/undici:6218:17
❯ wasm_on_message_complete node:internal/deps/undici/undici:5858:34
❯ null. wasm:/wasm/0002f80e:1:6425
❯ Parser.execute node:internal/deps/undici/undici:5971:26
❯ Parser.readMore node:internal/deps/undici/undici:5950:16
❯ Socket. node:internal/deps/undici/undici:6278:18
❯ Socket.emit node:events:513:28
This error originated in "test/diagnostics_channel.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "should support trace request by urllib:request and urllib:response". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
test/diagnostics_channel.test.ts
[failure] 224-224: test/diagnostics_channel.test.ts > diagnostics_channel.test.ts > should support trace socket info with H2 by undici:client:sendHeaders and undici:request:trailers
AssertionError: undefined == true
❯ test/diagnostics_channel.test.ts:224:5
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 18.19.0)
test/diagnostics_channel.test.ts
[failure] 224-224: test/diagnostics_channel.test.ts > diagnostics_channel.test.ts > should support trace socket info with H2 by undici:client:sendHeaders and undici:request:trailers
AssertionError: undefined == true
❯ test/diagnostics_channel.test.ts:224:5
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 18)
test/diagnostics_channel.test.ts
[failure] 224-224: test/diagnostics_channel.test.ts > diagnostics_channel.test.ts > should support trace socket info with H2 by undici:client:sendHeaders and undici:request:trailers
AssertionError: undefined == true
❯ test/diagnostics_channel.test.ts:224:5
🪛 GitHub Check: Node.js / Test (macos-latest, 18.19.0)
test/diagnostics_channel.test.ts
[failure] 224-224: test/diagnostics_channel.test.ts > diagnostics_channel.test.ts > should support trace socket info with H2 by undici:client:sendHeaders and undici:request:trailers
AssertionError: undefined == true
❯ test/diagnostics_channel.test.ts:224:5
🪛 GitHub Check: Node.js / Test (macos-latest, 18)
test/diagnostics_channel.test.ts
[failure] 224-224: test/diagnostics_channel.test.ts > diagnostics_channel.test.ts > should support trace socket info with H2 by undici:client:sendHeaders and undici:request:trailers
AssertionError: undefined == true
❯ test/diagnostics_channel.test.ts:224:5
🔇 Additional comments (2)
src/utils.ts (1)
175-177: LGTM
The addition correctly checks for the existence of autoSelectFamilyAttemptedAddresses and assigns it to socketInfo.
src/HttpClient.ts (1)
683-684: LGTM
Including res.socket in the debug logging enhances diagnostic capabilities and helps in tracing socket-related issues.
fengmk2
force-pushed
the
test-sendHeaders
branch
from
4358fb2 to
59a319f
Compare
| @@ -50,7 +50,7 @@ | |||
| "mime-types": "^2.1.35", | |||
| "qs": "^6.12.1", | |||
| "type-fest": "^4.20.1", | |||
| "undici": "^7.0.0", | |||
| "undici": "^7.1.1", | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
==========================================
- Coverage 95.82% 95.66% -0.16%
==========================================
Files 11 11
Lines 1270 1270
Branches 307 306 -1
==========================================
- Hits 1217 1215 -2
- Misses 49 51 +2
Partials 4 4 ☔ View full report in Codecov by Sentry. |
[skip ci] ## [4.6.9](v4.6.8...v4.6.9) (2024-12-17) ### Bug Fixes * should got undici:client:sendHeaders message on H2 ([#553](#553)) ([bd19f6d](bd19f6d))
closes #510
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Chores
undicidependency inpackage.json.