Skip to content

Added 'started' strategy for build notifications #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added 'started' strategy for build notifications #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/distributor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ Distributor.prototype._runNext = function(callback) {

executor.once('scmData', function(scmData) {
self._updateBuild(build, {scm: scmData});
self.notifier.send(build);
// run the same project again if we don't reach the latest rev
if (!scmData.isLatest) {
self.run({
Expand Down
8 changes: 3 additions & 5 deletions lib/notifier/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,6 @@ Notifier.prototype.send = function(build, callback) {

Steppy(
function() {
if (!build.completed) {
throw new Error('Build should be completed before notify');
}

var notify = build.project.notify;

// TODO: move to project validation during load
Expand All @@ -111,7 +107,9 @@ Notifier.prototype.send = function(build, callback) {
},
function(err, notify, prevBuild) {
var strategy = _(notify.on).find(function(strategy) {
if (strategy === 'done') {
if (strategy === 'started') {
return build.status === 'in-progress';
} else if (strategy === 'done') {
return build.status === 'done';
} else if (strategy === 'error') {
return build.status === 'error';
Expand Down