Skip to content

Conversation

@CheapDevotion
Copy link

While developing plugins for node-ci, I needed the ability to edit build files after they were checked out, but before the steps were run. To address this, I added a 'buildScmUpdated' event that is called right after a scm update is performed.

@okv
Copy link
Member

okv commented Mar 6, 2021

Hey there! Sorry for the late reply.
The event itself looks good 👍
But I think it would be better to emit it from _emitBuildUpdate function (which is called from _updateBuild ).
Could you also add some tests? (you might take a look at test/distributor/buildEvents.js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants