Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace torch.aten.outer with corresponding math #1084

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

rsuderman
Copy link
Contributor

Outer is missing lowerings in torch-mlir right now. To unblock we just explicitly do the unsqueeze and mul operators.

Outer is missing lowerings in `torch-mlir` right now. To unblock we just
explicitly do the unsqueeze and mul operators.
@rsuderman rsuderman requested a review from renxida March 13, 2025 21:31
Copy link
Contributor

@renxida renxida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems straightfoward. approved.

@ScottTodd
Copy link
Member

Tentative fix for #950. Hopefully @stbaione or someone else can reproduce and verify.

@stbaione
Copy link
Contributor

Tentative fix for #950. Hopefully @stbaione or someone else can reproduce and verify.

Was able to verify that the bug was due to torch >= 2.6.0

@ScottTodd
Copy link
Member

Tentative fix for #950. Hopefully @stbaione or someone else can reproduce and verify.

Was able to verify that the bug was due to torch >= 2.6.0

Does this PR fix the issue with torch 2.6.0?

@rsuderman rsuderman merged commit 38a739c into nod-ai:main Mar 14, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants