fix(launcher): guard null config in app provider query - #3952
Merged
Ly-sec merged 1 commit intoAug 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppProvider::query()read a config setting through a pointer that can be null. When it is null, it crashed. The fix checks for null first.Motivation
38/82 noctalia:desktop_entry_localization FAIL 0.21s killed by signal 11 SIGSEGVsince the launcher desktop-actions toggle (#3772). Made the launcher read
show_app_actionsthroughConfigService*which can be null without null check. Thedesktop_entry_localizationtest builds the providerwithout a config, so it segfaulted. Now a missing config just falls back to the default instead of crashing. Everything else is unchanged.
Type of Change
Testing
just formatandjust test, this time all the test passedManual Coverage
Screenshots / Videos
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installedassets/translations/en.json, or this PR adds no new user-facing strings.