fix(tray): hide passive status notifier items - #3795
Open
LuciusChen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passivefrom inline tray renderingMotivation
Clients such as udiskie implement smart tray behavior by changing their StatusNotifierItem from
ActivetoPassivewhen no removable devices are available. Noctalia tracked that change but continued rendering the item, leaving a stale-looking removable-drive icon after unplugging the device.Type of Change
Related Issue
Closes #3794
Testing
meson test -C build-debug tray_identifier --print-errorlogsmeson test -C build-debug tray_identifier fcitx_status icon_resolver --print-errorlogsgit diff --checkjustis not installed in the test environment)Manual Coverage
The original behavior was reproduced on Labwc with udiskie 2.7.0. The patched build was covered by focused unit tests but was not installed over the running packaged Noctalia session.
Screenshots / Videos
Not included; this changes whether an idle tray item is present rather than its visual styling.
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.Additional Notes
Unknown or empty status values remain visible for compatibility with incomplete third-party StatusNotifierItem implementations. Status matching is case-insensitive, consistent with the surrounding tray identifier normalization.