Skip to content

spotify-lyrics - #214

Draft
goatnath wants to merge 11 commits into
noctalia-dev:mainfrom
goatnath:main
Draft

spotify-lyrics#214
goatnath wants to merge 11 commits into
noctalia-dev:mainfrom
goatnath:main

Conversation

@goatnath

@goatnath goatnath commented Aug 2, 2026

Copy link
Copy Markdown

Plugin

  • Id: <goatnath/spotify-lyrics>
  • New plugin
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

Adds a seamless, time-synced scrolling lyrics panel for the Noctalia desktop shell. It integrates directly into the Noctalia bar via a small glyph next to the media widget, which toggle an auto-scrolling lyrics card pulled from a background daemon.

External dependencies

Requires playerctl and the syncedlyrics Python package. It uses a standalone background Python daemon (spotify_lyrics_daemon.py) to monitor media state and fetch lyrics without needing Spotify API keys. The plugin reads state locally from ~/.cache/noctalia/lyrics/current.json.

Testing

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Noctalia version tested against: Latest
  • Plugin API level: 3

Screenshots / Videos

recording_20260802_092705.mp4

Checklist

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • I created thumbnail.webp with the thumbnail generator.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

@goatnath

goatnath commented Aug 2, 2026

Copy link
Copy Markdown
Author

I have made the required changes suggested in the previous PR and I request you to check this and feel free to point out anything you think needs to be changed

@ItsLemmy

ItsLemmy commented Aug 2, 2026

Copy link
Copy Markdown
Contributor
  1. blocking - spotify-lyrics/plugin.toml:7

The manifest declares no dependencies, but spotify-lyrics/spotify_lyrics_daemon.py:6 requires the syncedlyrics Python package and spotify-lyrics/spotify_lyrics_daemon.py:101executes playerctl. The Python runtime is also required to run the daemon. spotify-lyrics/README.md:20 documents only part of this requirement outside the template's required
"## Requirements" section.

This hides mandatory runtime prerequisites from the catalog and plugin metadata. Declare all runtime requirements in dependencies and document the matching exact names under
"## Requirements".

@ItsLemmy
ItsLemmy marked this pull request as draft August 2, 2026 15:45
@goatnath
goatnath marked this pull request as ready for review August 3, 2026 04:58
@ItsLemmy

ItsLemmy commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
  1. blocking - lyrics/lyrics.luau:85

Commit ef91e6f modifies the existing h465855hgg/lyrics plugin, although this PR declares itself as a new goatnath/spotify-lyrics plugin and attests that it touches exactly one plugin directory.

Remove the lyrics/lyrics.luau change from this PR. Any update to the existing lyrics plugin should be reviewed separately with its own manifest version bump and functional scope.

@ItsLemmy
ItsLemmy marked this pull request as draft August 3, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants