fix: enable more linters

.golangci.yml

@@ -5,26 +5,22 @@ linters:
 
   disable:
     # TODO: remove the line and fix the issues
-    - depguard
     - err113
-    - forbidigo
-    - mnd
-    - inamedparam
     - ireturn
     - musttag
     - nestif
     - paralleltest
-    - predeclared
     - revive
     - wrapcheck
-    - wsl
 
     - cyclop # some functions need refactoring, I'll deal with that later
-    - nlreturn # keeps the code concise
+    - depguard # I'm not that pedantic
+    - exhaustruct # it's ok not to specify all the fields in a struct definition
     - godox # I like leaving TODOs in the code
-    - varnamelen # short variable names are okay
+    - nlreturn # keeps the code concise
+    - predeclared # need to rename the print action
     - testpackage # keep the tests close to the code
-    - exhaustruct # it's ok not to specify all the fields in a struct definition
+    - varnamelen # short variable names are okay
 
     # deprecated
     - exportloopref
@@ -43,11 +39,10 @@ issues:
         # using globals is recommended with spf13/cobra
         - gochecknoglobals
 
-    - path: internal/version
-      linters:
-        - gochecknoglobals
-
 linters-settings:
+  nolintlint:
+    require-explanation: true
+
   gci:
     sections:
       - standard

internal/actions/actions.go

@@ -35,5 +35,5 @@ func Map(client *gh.Client) ActionsMap {
 }
 
 type Runner interface {
-	Run(*notifications.Notification, []string, io.Writer) error
+	Run(n *notifications.Notification, params []string, out io.Writer) error
 }

internal/actions/print/print.go

@@ -1,6 +1,7 @@
 /*
 Package print implements an [actions.Runner] that prints a notification.
 */
+//nolint:forbidigo // This action is correctly named.
 package print
 
 import (

internal/actions/read/read.go

@@ -29,6 +29,7 @@ func (a *Runner) Run(n *notifications.Notification, _ []string, w io.Writer) err
 	if err != nil && err.Error() != "unexpected end of JSON input" {
 		return err
 	}
+
 	defer r.Body.Close()
 
 	n.Unread = false

internal/actions/tag/tag.go

@@ -55,6 +55,7 @@ func (*Runner) Run(n *notifications.Notification, tags []string, w io.Writer) er
 	n.Meta.Tags = append(n.Meta.Tags, tagsToAdd...)
 
 	newTags := []string{}
+
 	for _, tag := range n.Meta.Tags {
 		if !slices.Contains(tagsToRemove, tag) {
 			newTags = append(newTags, tag)

internal/api/api.go

@@ -6,5 +6,5 @@ import (
 )
 
 type Requestor interface {
-	Request(string, string, io.Reader) (*http.Response, error)
+	Request(method string, url string, body io.Reader) (*http.Response, error)
 }

internal/api/mock/calls.go

@@ -49,6 +49,7 @@ func LoadCallsFromFile(path string) ([]Call, error) {
 	}
 
 	calls := make([]Call, len(rawCalls))
+
 	for i, rawCall := range rawCalls {
 		body, err := json.Marshal(rawCall.Response.Body)
 		if err != nil {

internal/api/mock/mock.go

@@ -46,6 +46,7 @@ func (m *Mock) call(verb, endpoint string) (Call, error) {
 	}
 
 	m.index++
+
 	slog.Debug("mock call", "verb", verb, "endpoint", endpoint, "call", call)
 
 	return call, nil

internal/cache/cache.go

@@ -13,13 +13,14 @@ import (
 	"log/slog"
 	"os"
 	"path/filepath"
+	"syscall"
 	"time"
 )
 
 type RefreshReadWriter interface {
-	Read(any) error
-	Write(any) error
-	Refresh(time.Time)
+	Read(d any) error
+	Write(d any) error
+	Refresh(t time.Time)
 	RefreshedAt() time.Time
 }
 
@@ -47,6 +48,7 @@ func (c *FileCache) Read(out any) error {
 			slog.Debug("cache doesn't exist", "path", c.path)
 			return nil
 		}
+
 		return err
 	}
 
@@ -93,9 +95,16 @@ func (c *FileCache) Write(in any) error {
 		return err
 	}
 
-	if err := os.MkdirAll(filepath.Dir(c.path), 0o755); err != nil {
+	if err := os.MkdirAll(
+		filepath.Dir(c.path),
+		syscall.S_IRUSR|syscall.S_IWUSR|syscall.S_IXUSR,
+	); err != nil {
 		return err
 	}
 
-	return os.WriteFile(c.path, marshaled, 0o600)
+	return os.WriteFile(
+		c.path,
+		marshaled,
+		syscall.S_IRUSR|syscall.S_IWUSR,
+	)
 }

internal/cmd/config.go

@@ -46,6 +46,8 @@ func runConfig(_ *cobra.Command, _ []string) error {
 	if err != nil {
 		return err
 	}
+
+	//nolint:forbidigo // This is an expected print statement.
 	fmt.Printf("Config sourced from: %s\n\n%s\n", config.Path, marshaled)
 
 	return nil
@@ -66,6 +68,8 @@ func initConfig() error {
 		slog.Error("Failed to save initial config", "err", err)
 		return err
 	}
+
+	//nolint:forbidigo // This is an expected print statement.
 	fmt.Printf("Initial config saved to %s\n", initialPath)
 
 	return nil

internal/cmd/root.go

@@ -54,7 +54,7 @@ func Execute() error {
 	return rootCmd.Execute()
 }
 
-//nolint:lll
+//nolint:lll // Having the whole flag definition on a single line is OK.
 func init() {
 	rootCmd.Root().CompletionOptions.DisableDefaultCmd = true
 
@@ -79,6 +79,7 @@ func setupGlobals(_ *cobra.Command, _ []string) error {
 	logger.Init(verbosityFlag)
 
 	var err error
+
 	config, err = configPkg.New(configPathFlag)
 	if err != nil {
 		slog.Error("Failed to load the config", "path", configPathFlag, "err", err)
@@ -188,7 +189,10 @@ func display(notifications notifications.Notifications) error {
 }
 
 func displayTable(n notifications.Notifications) {
+	//nolint:forbidigo // This is an expected print statement.
 	fmt.Println(n)
+
+	//nolint:forbidigo // This is an expected print statement.
 	fmt.Printf("Found %d notifications %s\n",
 		len(n),
 		text.RelativeTimeAgo(
@@ -204,13 +208,15 @@ func displayJSON(notifications notifications.Notifications) error {
 		return err
 	}
 
+	//nolint:forbidigo // This is an expected print statement.
 	fmt.Printf("%s\n", marshaled)
 
 	return nil
 }
 
 func displayTags(n notifications.Notifications) error {
 	for tag, count := range n.TagsMap() {
+		//nolint:forbidigo // This is an expected print statement.
 		fmt.Printf("%s: %d\n", tag, count)
 	}
 
@@ -223,6 +229,7 @@ func displayRepl(n notifications.Notifications) error {
 		slog.Error("Failed to create an API REST client", "err", err)
 		return err
 	}
+
 	manager.SetCaller(caller)
 
 	// Launching bubbletea will occupy STDOUT and STDERR, so we need to redirect

internal/cmd/sync.go

@@ -41,7 +41,7 @@ See synchronization logic at https://pkg.go.dev/github.com/nobe4/gh-not/internal
 	}
 )
 
-//nolint:lll
+//nolint:lll // Having the whole flag definition on a single line is OK.
 func init() {
 	rootCmd.AddCommand(syncCmd)
 
@@ -53,6 +53,7 @@ func init() {
 
 func runSync(_ *cobra.Command, _ []string) error {
 	var caller api.Requestor
+
 	var err error
 
 	if notificationDumpPath != "" {
@@ -64,6 +65,7 @@ func runSync(_ *cobra.Command, _ []string) error {
 			return err
 		}
 	}
+
 	manager.SetCaller(caller)
 
 	manager.ForceStrategy = forceStrategy
@@ -73,25 +75,29 @@ func runSync(_ *cobra.Command, _ []string) error {
 		slog.Error("Failed to load the notifications", "err", err)
 		return err
 	}
+
 	loadedNotifications := len(manager.Notifications)
 
 	if err := manager.Refresh(); err != nil {
 		slog.Error("Failed to refresh the notifications", "err", err)
 		return err
 	}
+
 	refreshedNotifications := len(manager.Notifications)
 
 	if err := manager.Apply(); err != nil {
 		slog.Error("Failed to applying rules", "err", err)
 		return err
 	}
+
 	visibleNotifications := len(manager.Notifications.Visible())
 
 	if err := manager.Save(); err != nil {
 		slog.Error("Failed to save the notifications", "err", err)
 		return err
 	}
 
+	//nolint:forbidigo // This is an expected print statement.
 	fmt.Printf("Loaded %d, refreshed %d, visible %d at %s\n",
 		loadedNotifications,
 		refreshedNotifications,

internal/config/config.go

@@ -36,7 +36,7 @@ type Data struct {
 
 // Endpoint is the configuration for the GitHub API endpoint.
 //
-//nolint:lll
+//nolint:lll // Links can be long.
 type Endpoint struct {
 	// Pull all notifications from the endpoint.
 	// By default, only the unread notifications are fetched.
@@ -77,6 +77,7 @@ type View struct {
 
 func Default(path string) (*viper.Viper, string) {
 	slog.Debug("loading default configuration")
+
 	if path == "" {
 		path = filepath.Join(ConfigDir(), "config.yaml")
 		slog.Debug("path is empty, setting default path", "default path", path)
@@ -110,6 +111,7 @@ func New(path string) (*Config, error) {
 			return nil, err
 		}
 	}
+
 	c.Path = c.viper.ConfigFileUsed()
 
 	if err := c.viper.Unmarshal(&c.Data); err != nil {

internal/config/defaults.go

@@ -2,7 +2,7 @@ package config
 
 import "path"
 
-//nolint:gochecknoglobals
+//nolint:gochecknoglobals,mnd // This is used as a default in a couple of places.
 var Defaults = map[string]any{
 	"cache.ttl_in_hours": 1,
 	"cache.path":         path.Join(StateDir(), "cache.json"),

internal/config/keymap.go

@@ -13,7 +13,7 @@ type (
 
 type KeyBinding []string
 
-//nolint:gochecknoglobals
+//nolint:gochecknoglobals // This replacement list is used a lot.
 var unicodeReplacement = []string{
 	"up", "↑",
 	"down", "↓",
@@ -28,6 +28,7 @@ var unicodeReplacement = []string{
 
 func (k Keymap) Binding(mode, action string) key.Binding {
 	keys := k[mode][action]
+
 	return key.NewBinding(
 		key.WithKeys(keys...),
 		key.WithHelp(keys.Help(), action),

internal/config/path.go

@@ -28,6 +28,7 @@ func ConfigDir() string {
 		d, _ := os.UserHomeDir()
 		path = filepath.Join(d, ".config", "gh-not")
 	}
+
 	return path
 }
 
@@ -42,5 +43,6 @@ func StateDir() string {
 		c, _ := os.UserHomeDir()
 		path = filepath.Join(c, ".local", "state", "gh-not")
 	}
+
 	return path
 }

internal/gh/enrichments.go

@@ -27,6 +27,7 @@ func (c *Client) Enrich(n *notifications.Notification) error {
 	if err != nil {
 		return err
 	}
+
 	n.Author = threadExtra.User
 	n.Subject.State = threadExtra.State
 	n.Subject.HTMLURL = threadExtra.HTMLURL
@@ -38,6 +39,7 @@ func (c *Client) Enrich(n *notifications.Notification) error {
 	if err != nil {
 		return err
 	}
+
 	n.LatestCommentor = LastCommentor
 
 	return nil
@@ -49,10 +51,12 @@ func (c *Client) getThreadExtra(n *notifications.Notification) (ThreadExtra, err
 	}
 
 	slog.Debug("getting the thread extra", "id", n.ID, "url", n.Subject.URL)
+
 	resp, err := c.API.Request(http.MethodGet, n.Subject.URL, nil)
 	if err != nil {
 		return ThreadExtra{}, err
 	}
+
 	defer resp.Body.Close()
 
 	body, err := io.ReadAll(resp.Body)
@@ -61,6 +65,7 @@ func (c *Client) getThreadExtra(n *notifications.Notification) (ThreadExtra, err
 	}
 
 	extra := ThreadExtra{}
+
 	err = json.Unmarshal(body, &extra)
 	if err != nil {
 		return ThreadExtra{}, err
@@ -75,10 +80,12 @@ func (c *Client) getLastCommentor(n *notifications.Notification) (notifications.
 	}
 
 	slog.Debug("getting the last commentor", "id", n.ID, "url", n.Subject.LatestCommentURL)
+
 	resp, err := c.API.Request(http.MethodGet, n.Subject.LatestCommentURL, nil)
 	if err != nil {
 		return notifications.User{}, err
 	}
+
 	defer resp.Body.Close()
 
 	body, err := io.ReadAll(resp.Body)
@@ -89,6 +96,7 @@ func (c *Client) getLastCommentor(n *notifications.Notification) (notifications.
 	comment := struct {
 		User notifications.User `json:"user"`
 	}{}
+
 	err = json.Unmarshal(body, &comment)
 	if err != nil {
 		return notifications.User{}, err