feat: enable predeclared and nlreturn (#241)

Author: nobe4

.golangci.yml

@@ -7,8 +7,6 @@ linters:
     - cyclop # some functions need refactoring, I'll deal with that later
     - exhaustruct # it's ok not to specify all the fields in a struct definition
     - godox # I like leaving TODOs in the code
-    - nlreturn # keeps the code concise
-    - predeclared # need to rename the print action
     - testpackage # keep the tests close to the code
     - varnamelen # short variable names are okay
 

internal/actions/assign/assign.go

@@ -56,6 +56,7 @@ func (a *Runner) Run(n *notifications.Notification, assignees []string, w io.Wri
 	url, ok := issueURL(n.Subject.URL)
 	if !ok {
 		slog.Warn("not an issue or pull", "notification", n)
+
 		return nil
 	}
 

internal/actions/print/print.go

@@ -1,7 +1,7 @@
 /*
 Package print implements an [actions.Runner] that prints a notification.
 */
-//nolint:forbidigo // This action is correctly named.
+//nolint:forbidigo,predeclared // This action is correctly named.
 package print
 
 import (

internal/cache/cache.go

@@ -48,6 +48,7 @@ func (c *File) Read(out any) error {
 	if err != nil {
 		if errors.Is(err, os.ErrNotExist) {
 			slog.Debug("cache doesn't exist", "path", c.path)
+
 			return nil
 		}
 

internal/cmd/root.go

@@ -107,11 +107,13 @@ func runRoot(_ *cobra.Command, _ []string) error {
 	n, err := filter(n)
 	if err != nil {
 		slog.Error("Failed to filter the notifications", "err", err)
+
 		return err
 	}
 
 	if err := display(n); err != nil {
 		slog.Error("Failed to display the notifications", "err", err)
+
 		return err
 	}
 
@@ -156,6 +158,7 @@ func filter(n notifications.Notifications) (notifications.Notifications, error)
 
 		if !found {
 			slog.Error("Rule not found", "rule", ruleFlag)
+
 			return nil, fmt.Errorf("invalid rule '%s': %w", ruleFlag, errRuleNotFound)
 		}
 	}

internal/gh/gh.go

@@ -128,6 +128,7 @@ func (c *Client) retry(verb, endpoint string, body io.Reader) ([]*notifications.
 
 		if isRetryable(err) {
 			slog.Warn("endpoint failed with retryable error", "error", err, "endpoint", endpoint, "retry left", i)
+
 			continue
 		}
 

internal/manager/manager.go

@@ -118,6 +118,7 @@ func (m *Manager) Apply() error {
 		runner, ok := m.Actions[rule.Action]
 		if !ok {
 			slog.Error("unknown action", "action", rule.Action)
+
 			continue
 		}
 
@@ -131,12 +132,14 @@ func (m *Manager) Apply() error {
 		for _, notification := range selectedNotifications {
 			if notification.Meta.Done && !m.ForceStrategy.Has(ForceApply) {
 				slog.Debug("skipping done notification", "id", notification.ID)
+
 				continue
 			}
 
 			if m.ForceStrategy.Has(ForceNoop) {
 				//nolint:forbidigo // This is an expected print statement.
 				fmt.Printf("NOOP'ing action %s on notification %s\n", rule.Action, notification.String())
+
 				continue
 			}
 

internal/manager/strategies.go

@@ -45,16 +45,19 @@ func (r *RefreshStrategy) ShouldRefresh(expired bool) bool {
 	switch *r {
 	case ForceRefresh:
 		slog.Info("forcing a refresh")
+
 		return true
 
 	case PreventRefresh:
 		slog.Info("preventing a refresh")
+
 		return false
 
 	case AutoRefresh:
 		fallthrough
 	default:
 		slog.Debug("refresh based on cache expiration", "expired", expired)
+
 		return expired
 	}
 }

internal/notifications/notifications.go

@@ -100,6 +100,7 @@ func (n Notifications) Equal(others Notifications) bool {
 	for i, n := range n {
 		if !n.Equal(others[i]) {
 			slog.Info("notification not equal", "n", n.Debug(), "other", others[i].Debug())
+
 			return false
 		}
 	}

internal/notifications/sync.go

@@ -69,6 +69,7 @@ func Sync(local, remote Notifications) Notifications {
 			if local[i].Meta.Done || local[i].Meta.Hidden {
 				// (4) Drop
 				slog.Debug("sync", "action", "drop", "id", local[i].ID)
+
 				continue
 			}