fix: move back to permission numbers (#240)

Author: nobe4

.golangci.yml

@@ -5,7 +5,6 @@ linters:
 
   disable:
     - cyclop # some functions need refactoring, I'll deal with that later
-    - depguard # I'm not that pedantic
     - exhaustruct # it's ok not to specify all the fields in a struct definition
     - godox # I like leaving TODOs in the code
     - nlreturn # keeps the code concise
@@ -46,6 +45,34 @@ linters-settings:
       - default
       - localmodule
 
+  mnd:
+    ignored-numbers:
+      # UNIX permissions mask
+      - "0o700" # rwx------
+      - "0o600" # rw-------
+
+    ignored-functions:
+      # Functions that require a UNIX permissions mask
+      - "os.WriteFile"
+      - "os.OpenFile"
+      - "os.MkdirAll"
+
+  depguard:
+    rules:
+      main:
+        files:
+          - $all
+        allow:
+          - $gostd
+          - github.com/cli/go-gh
+          - github.com/nobe4/gh-not
+          - github.com/charmbracelet/bubbletea
+          - github.com/charmbracelet/bubbles
+          - github.com/charmbracelet/lipgloss
+          - github.com/spf13/cobra
+          - github.com/spf13/viper
+          - github.com/itchyny/gojq
+
   revive:
     enable-all-rules: true
     rules:

internal/cache/cache.go

@@ -14,7 +14,6 @@ import (
 	"log/slog"
 	"os"
 	"path/filepath"
-	"syscall"
 	"time"
 )
 
@@ -98,18 +97,11 @@ func (c *File) Write(in any) error {
 		return fmt.Errorf("failed to marshal cache: %w", err)
 	}
 
-	if err := os.MkdirAll(
-		filepath.Dir(c.path),
-		syscall.S_IRUSR|syscall.S_IWUSR|syscall.S_IXUSR,
-	); err != nil {
+	if err := os.MkdirAll(filepath.Dir(c.path), 0o700); err != nil {
 		return fmt.Errorf("failed to create cache directory: %w", err)
 	}
 
-	if err := os.WriteFile(
-		c.path,
-		marshaled,
-		syscall.S_IRUSR|syscall.S_IWUSR,
-	); err != nil {
+	if err := os.WriteFile(c.path, marshaled, 0o600); err != nil {
 		return fmt.Errorf("failed to write cache: %w", err)
 	}
 

internal/logger/logger.go

@@ -5,15 +5,14 @@ import (
 	"io"
 	"log/slog"
 	"os"
-	"syscall"
 )
 
 func Init(verbosity int) {
 	initWithWriter(os.Stderr, verbosity)
 }
 
 func InitWithFile(verbosity int, path string) (*os.File, error) {
-	f, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_APPEND, syscall.S_IRUSR|syscall.S_IWUSR)
+	f, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_APPEND, 0o600)
 	if err != nil {
 		return nil, fmt.Errorf("error opening file for logging: %w", err)
 	}