Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize golang dependencies like controller-runtime and k8s #1288

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Jan 23, 2025

Is this a BUG FIX or a FEATURE ?:

/kind enhancement

What this PR does / why we need it:
The golang dependencies are quite old and at unmaintained versions, this change bumps the bigs ones like controller-runtime and k8s to the new ones.

Modernize golang dependencies

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 23, 2025
@qinqon qinqon force-pushed the make-snyk-happy branch 12 times, most recently from a3f01cb to badbab4 Compare January 23, 2025 16:27
@qinqon
Copy link
Member Author

qinqon commented Jan 24, 2025

/retest

@qinqon qinqon force-pushed the make-snyk-happy branch 3 times, most recently from 3515ab2 to ca49ffa Compare January 24, 2025 09:36
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2025
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2025
@qinqon qinqon force-pushed the make-snyk-happy branch 2 times, most recently from 8318f73 to 6e6eb02 Compare January 29, 2025 10:55
@qinqon
Copy link
Member Author

qinqon commented Feb 6, 2025

/retest

@qinqon qinqon force-pushed the make-snyk-happy branch 2 times, most recently from 1b3a5f3 to 4a60a15 Compare February 6, 2025 09:41
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 6, 2025
@qinqon qinqon changed the title security: Bump go.mod to make snyk happy Moderniza dependencies like controller-runtime and k8s Feb 6, 2025
@qinqon qinqon changed the title Moderniza dependencies like controller-runtime and k8s Moderniza golang dependencies like controller-runtime and k8s Feb 6, 2025
Signed-off-by: Enrique Llorente <[email protected]>
@qinqon qinqon changed the title Moderniza golang dependencies like controller-runtime and k8s Modernize golang dependencies like controller-runtime and k8s Feb 6, 2025
@mkowalski
Copy link
Member

/test pull-kubernetes-nmstate-e2e-handler-k8s

Some tests failed with an incorrect result

Signed-off-by: Enrique Llorente <[email protected]>
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qinqon. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Collaborator

@qinqon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s ca88f7e link true /test pull-kubernetes-nmstate-e2e-handler-k8s
pull-kubernetes-nmstate-e2e-handler-k8s-future ca88f7e link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants