-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a second example #21
base: main
Are you sure you want to change the base?
Conversation
Just noticing this draft PR. |
Regarding the error about |
@@ -5,7 +5,7 @@ | |||
"sideEffects": false, | |||
"type": "module", | |||
"scripts": { | |||
"build": "NODE_ENV=production react-router build", | |||
"build": "NODE_ENV=production pnpm fbtee:manifest && pnpm fbtee:collect && pnpm fbtee:translate && react-router build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't pnpm fbtee:translate && react-router build
suffice here, as it anyways works on a different set of files then the ones created by manifest and collect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translate command needs .source_strings.json
.
3b83a0c
to
acd251f
Compare
This adds a second sample.
From my perspective the following gaps:
Uncaught SyntaxError: Identifier 'RefreshRuntime' has already been declared (at root.tsx:29:1)
. I assume some issue with the HMR due to the React Router and React Vite plugins.Not actually deployed yet, so we'd need to check if it works when deployed.