Fixing the account selection dismiss is blocking the UI

nkuppan · Jan 23, 2025 · 59a5cf1 · 59a5cf1
1 parent e9645a8
commit 59a5cf1
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 336 deletions.
diff --git a/.idea/compiler.xml b/.idea/compiler.xml
diff --git a/.idea/other.xml b/.idea/other.xml
diff --git a/...ntion/src/main/java/com/naveenapps/expensemanager/buildsrc/extensions/AndroidConfigExt.kt b/...ntion/src/main/java/com/naveenapps/expensemanager/buildsrc/extensions/AndroidConfigExt.kt
@@ -7,8 +7,8 @@ import com.android.build.gradle.LibraryExtension
 import org.gradle.api.Project
 import org.gradle.kotlin.dsl.dependencies
 
-const val TARGET_SDK = 34
-const val COMPILE_SDK: Int = 34
+const val TARGET_SDK = 35
+const val COMPILE_SDK: Int = 35
 const val MIN_SDK = 21
 
 const val VERSION_NAME = "1.2.7"

diff --git a/...c/main/kotlin/com/naveenapps/expensemanager/core/designsystem/ui/extensions/ContextExt.kt b/...c/main/kotlin/com/naveenapps/expensemanager/core/designsystem/ui/extensions/ContextExt.kt
@@ -62,7 +62,7 @@ fun Context.shareThisFile(fileUri: Uri) {
 fun Context.getAppVersionName(): String {
     return try {
         val pInfo: PackageInfo = packageManager.getPackageInfo(packageName, 0)
-        pInfo.versionName
+        pInfo.versionName ?: ""
     } catch (e: PackageManager.NameNotFoundException) {
         e.printStackTrace()
         ""

diff --git a/...otlin/com/naveenapps/expensemanager/feature/transaction/create/TransactionCreateScreen.kt b/...otlin/com/naveenapps/expensemanager/feature/transaction/create/TransactionCreateScreen.kt
@@ -162,7 +162,7 @@ private fun AccountSelectionView(
 ) {
     ModalBottomSheet(
         onDismissRequest = {
-            onAction.invoke(TransactionCreateAction.DismissCategorySelection)
+            onAction.invoke(TransactionCreateAction.DismissAccountSelection)
         },
         containerColor = MaterialTheme.colorScheme.background,
         tonalElevation = 0.dp,
@@ -483,7 +483,7 @@ private fun TransactionCreateStatePreview() {
                     name = "Shopping",
                     type = CategoryType.EXPENSE,
                     StoredIcon(
-                        name = "ic_calendar",
+                        name = "account_balance_wallet",
                         backgroundColor = "#000000",
                     ),
                     createdOn = Date(),
@@ -494,7 +494,7 @@ private fun TransactionCreateStatePreview() {
                     name = "Shopping",
                     type = AccountType.REGULAR,
                     storedIcon = StoredIcon(
-                        name = "ic_calendar",
+                        name = "account_balance_wallet",
                         backgroundColor = "#000000",
                     ),
                     amountTextColor = com.naveenapps.expensemanager.core.common.R.color.red_500,
@@ -505,7 +505,7 @@ private fun TransactionCreateStatePreview() {
                     name = "Shopping",
                     type = AccountType.REGULAR,
                     storedIcon = StoredIcon(
-                        name = "ic_calendar",
+                        name = "account_balance_wallet",
                         backgroundColor = "#000000",
                     ),
                     amountTextColor = com.naveenapps.expensemanager.core.common.R.color.green_500,