Extend MATXSR to handle dilution dependent spec and prod arrays of GROUPR #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi, just wanted to let you know that I fixed the CI error. Cheers, |
Contributor
Author
|
This PR can be closed because #274 contains it and is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NJOY2016.49 GROUPR learned to create MF6 MT18 spec and prod arrays to be stored in the output GENDF file based on issue #118 .
This leads to the situation that the GENDF section MF6 MT18 contains for each group NZ dilution dependent spec and prod values, where MATXSR expected only one value. Consequently, the spec and prod arrays in record 10d of the output file were simply wrong.
This fix lets MATXSR use the dilution dependent value according to the sub-material i.e. the dilution/temperature pair.
Probably solves #168 .