Fix syntax errors in check_compilation.bat and use gradle 8 instead#17
Merged
kelloggm merged 1 commit intonjit-jerse:mainfrom Sep 5, 2025
Merged
Fix syntax errors in check_compilation.bat and use gradle 8 instead#17kelloggm merged 1 commit intonjit-jerse:mainfrom
check_compilation.bat and use gradle 8 instead#17kelloggm merged 1 commit intonjit-jerse:mainfrom
Conversation
kelloggm
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kind of reverts #16, since gradle 9 was messing with some of the error outputs. For the refactor, CF-1291 changed from failing to succeeding after changing to gradle 8.
The problem was that file name and line number wasn't being outputted when running gradlew build, so the regex matching wasn't picking up on the error, even though the error itself was in the logs.