Support more options for icon in lualine #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaetanLepage
requested changes
Dec 5, 2023
plugins/statuslines/lualine.nix
Outdated
| @@ -36,7 +36,7 @@ with lib; let | |||
| Enables the display of icons alongside the component. | |||
| ''; | |||
|
|
|||
| icon = helpers.mkNullOrOption types.str '' | |||
| icon = helpers.mkNullOrOption (types.either types.str helpers.rawType) '' | |||
There was a problem hiding this comment.
Suggested change
| icon = helpers.mkNullOrOption (types.either types.str helpers.rawType) '' | |
| icon = helpers.mkNullOrOption (with types; either str (attrsOf anything)) '' |
There was a problem hiding this comment.
Thanks for showing me the change.
I am trying to test locally before pushing the change.
I am having a problem on the generation.
I think something else needs to be define maybe here https://github.com/nix-community/nixvim/blob/main/plugins/statuslines/lualine.nix#L214. in order to handle the unkeyed value for the icon.
I've tried several things with no success. maybe you can point me to some example to use as base.
Thanks.
adalessa
force-pushed
the
feature/lualine-icons
branch
from
c42f686 to
1819d6b
Compare
|
@GaetanLepage After several tries and many errors I was able to find the solution to properly map the icon property, and from my tests works as expected. Please let me know what you think. |
Co-authored-by: Gaétan Lepage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From lualine documentation the icons can be configure more than just an string
https://github.com/nvim-lualine/lualine.nvim#general-component-options
example
{'branch', icon = {'', align='right', color={fg='green'}}}Currently is defined as string which cover for most of the cases but if you want to set a color or more is not possible. I think that adding support for raw type makes more extensible.
I think also setting an object is possible but I lack the knowledge to do so, with this I was able to extend my configuration as I needed.
Let me know what do you think.
Kind regards, thanks for maintaining the project.