Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ktlint: enable formatter and diagnostics #729

Merged
merged 1 commit into from
Nov 23, 2023
Merged

ktlint: enable formatter and diagnostics #729

merged 1 commit into from
Nov 23, 2023

Conversation

MikaelFangel
Copy link
Contributor

@MikaelFangel MikaelFangel commented Nov 23, 2023 •
edited
Loading

Changes

  • Enable ktlint as a none-ls formatter
  • Enable ktlint as a none-ls diagnostics tool
  • Add tests for both cases

Checks

  • Alejandra style
  • Flake check

GaetanLepage
GaetanLepage approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks !

@GaetanLepage GaetanLepage merged commit a88b955 into nix-community:main Nov 23, 2023
1 check passed
@MikaelFangel MikaelFangel deleted the init-ktlint branch November 23, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikaelFangel @GaetanLepage