Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/efmls-configs: Improve tool installation #705

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

traxys
Copy link
Member

@traxys traxys commented Nov 16, 2023

This adds a few missing tools, and adds the following behaviours:

  • Warning when selecting a tool nixvim is not able to install (it is either too new and was not added, or not packaged in nixpkgs)
  • Allow to override tool packages (this is usefull for example for mdformat that can have plugins added to it)

This commit allows to:
 - Override the package used for a tool
 - Warn if nixvim can't install a tool
@traxys traxys requested a review from GaetanLepage November 16, 2023 17:06
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool ! Just one minor suggestion.

plugins/lsp/language-servers/efmls-configs.nix Outdated Show resolved Hide resolved
@traxys traxys requested a review from GaetanLepage November 16, 2023 21:52
@traxys traxys merged commit a304b68 into nix-community:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants