plugins/catppuccin!: update integrations #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtnvgr
commented
Oct 25, 2023
mrtnvgr
changed the title
|
I think we need a type which would allow for |
|
@mrtnvgr is your PR now ready for review ? If so, don't hesitate to undraft it accordingly so that I take a closer look. |
GaetanLepage
reviewed
Nov 9, 2023
plugins/colorschemes/catppuccin.nix
Outdated
| beacon = helpers.defaultNullOpts.mkBool false ""; | ||
|
|
||
| # TODO: bufferline = ; |
There was a problem hiding this comment.
You still have a few TODOs left
There was a problem hiding this comment.
These TODOs are special integrations which require additional setup in other plugins. I need help to implement them
There was a problem hiding this comment.
Ok, let's leave them as is for now.
GaetanLepage
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates catppuccin integrations and sorts them to alphabetical order