Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/plugins/utils/spectre: enable tests on Darwin #1961

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

elohmeier
Copy link
Contributor

@elohmeier elohmeier commented Aug 1, 2024

The module 'plenary.job' not found issue has been resolved and tests can be executed on Darwin.

Tests should be updated for Darwin to handle the missing sed warning (ERROR: You need to install gnu sed 'brew install gnu-sed') as soon as #1952 is resolved. (e.g. this failure)

@GaetanLepage
Copy link
Member

#1952 has been merged

@GaetanLepage
Copy link
Member

@Mergifyio queue

@GaetanLepage
Copy link
Member

Thanks @elohmeier !

Copy link
Contributor

mergify bot commented Aug 14, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at a96aa97

@GaetanLepage
Copy link
Member

https://github.com/Mergifyio unqueue

Copy link
Contributor

mergify bot commented Aug 14, 2024

unqueue

☑️ The pull request is not queued

@mergify mergify bot merged commit a96aa97 into nix-community:main Aug 14, 2024
4 checks passed
@mergify mergify bot temporarily deployed to github-pages August 14, 2024 21:50 Inactive
@elohmeier elohmeier deleted the spectre-enable-tests branch August 15, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants