Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jellyseerr service #53

Closed
wants to merge 4 commits into from
Closed

Conversation

pizzapim
Copy link
Collaborator

Unsure how to improve the user experience on this one. Jellyseerr tries to write run-time config to ${cfg.package}/libexec/jellyseerr/deps/jellyseerr/config/ NixOS has solved this by bind-mounting that directory to /var/lib/jellyseerr. In the container world this should obviously be a mounted volume, but without reading the source code it would be hard for a user to find out about where to mount. Also if the package is updated this location would change.

@pizzapim pizzapim requested a review from MagicRB December 15, 2024 22:21
@MagicRB
Copy link
Collaborator

MagicRB commented Dec 15, 2024

We either patch the source code or we could maybe get https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/li/libredirect/package.nix to work.

@pizzapim pizzapim marked this pull request as ready for review December 16, 2024 21:15
@pizzapim
Copy link
Collaborator Author

Well that was easy.

@pizzapim pizzapim marked this pull request as draft December 16, 2024 21:22
@pizzapim
Copy link
Collaborator Author

pizzapim commented Dec 16, 2024

Actually let me verify this works with a newer version of Jellyseerr as the nixpkgs one is outdated.

@pizzapim
Copy link
Collaborator Author

There is actually a nixpkgs PR to update the package, which seems to work great. So this is good to go in the mean time.

@pizzapim pizzapim marked this pull request as ready for review December 17, 2024 17:56
@MagicRB
Copy link
Collaborator

MagicRB commented Dec 17, 2024

Are we running this as root? any reason or just didn't do it?

@pizzapim
Copy link
Collaborator Author

Oh yeah. Actually, let me finish the user/group PR first then.

@pizzapim pizzapim closed this Jan 4, 2025
@pizzapim pizzapim deleted the jellyseerr branch January 4, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants