Skip to content

Conversation

@nitronit
Copy link
Owner

Testing rabbit

boojamya and others added 30 commits January 23, 2023 14:25
* Fix single signer state load bug

* Don't create sign state in config init for single signer

* Add unsupported warnings for single-signer mode

* Use Fprintln to cmd stdout for single signer warning

* Require accept-risk flag for single signer mode
* Phase 1 of ICS

* Fix leader election flaky test (strangelove-ventures#133)

* Handle feedback

* fix lint

* remove remaining log.Fatal calls

* split cosigner/single signer key file methods
* Wait for sign state flush on stop

* swap out WaitAndTerminate wait group for channel

* Handle feedback

* godoc tidy
* Update linter to be more strict around import aliases and introduce revive

* Updates for golangci-lint 1.52

* fix broken test. tidy
* single signer multi chain

* enforce interface impl

* cmd impl

* lint imports

* restore check on key file

* Add mutex for map rw

* Preload pubkey

* lint

* Update to sync.Map for chainState

* Update comment for state file disk creation

* Add comment for file pv mutex
* Make threshold validator chain ID agnostic

* Feedback
…-ventures#122)

* Track chain IDs in separate chain state caches. Remove chain ID from config and determine automatically from block sign requests. Enable a single horcrux cluster to sign multiple networks at once with the same private key.

* Fix lint

* Add horcrux multi-chain test

* Fix lint

* add chain id log

* Add chain id and hrs to leader logs

* enrich error logs

* initialize map

* add single signer test and additional double sign assertions

* aliases to lowercase

* wait for async sign state saves before shutdown in tests and runtime

* Fix lint and race before tmp dir deletion

* Remove no longer relevant comment
tidy

* swap out WaitAndTerminate wait group for channel

* Merge main

* Add comment for TestIsRunning not working on macOS
* Bump to go v1.20

* Implement errors.Join suggestions

* Simplify errors.Join returns

* Fix TestIsRunning for go 1.20

* lint

* bump gomod

* Feedback

* lint
* swap tendermint with cometbft v0.37.0

* Fork of grpc-multi-resolver for compatibility with grpc 1.54

* Import aliases and docs updates

* Updates for sdk 47

* cbft -> comet for import aliases

* Remove stale comment
* key assignment feature

* lint

* Add migrate command

* Simplify key2shares. Make TestMultipleChainHorcrux use different priv keys for each chain

* fix key2shares test

* handle feedback

* Fix non-out-dir, update docs

* Fix test

* lint
…gelove-ventures#147)

* One config file for all signers

* Update docs

* Fix test

* Fix cosigner cmd

* Bump test timeout

* handle feedback on naming

* lint

* fix testdata rsa_keys.json

* fix cosigners from flag test

* consolidate start command. panic if config is v2 format
* tidy up usage and flags

* Fix sign mode flag description

* nits

* add --bare flag to config init to disable validation

* update test data
* migrate grpc-multi-resolver to internal to remove replace. bump raft libs

* remove unused file, enforce interface impl
* Use dash for cosigner dirs. Create state dir on startup if doesn't exist

* go back to underscore
…ventures#155)

Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.1.3 to 1.1.5.
- [Release notes](https://github.com/opencontainers/runc/releases)
- [Changelog](https://github.com/opencontainers/runc/blob/main/CHANGELOG.md)
- [Commits](opencontainers/runc@v1.1.3...v1.1.5)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/runc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* set and get nonces concurrently

* handle feedback
* nonce rename

* lint

* feedback
…ventures#163)

Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.47.1 to 0.47.3.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@v0.47.1...v0.47.3)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-sdk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ventures#167)

Bumps [github.com/cometbft/cometbft](https://github.com/cometbft/cometbft) from 0.37.0 to 0.37.2.
- [Release notes](https://github.com/cometbft/cometbft/releases)
- [Changelog](https://github.com/cometbft/cometbft/blob/main/CHANGELOG.md)
- [Commits](cometbft/cometbft@v0.37.0...v0.37.2)

---
updated-dependencies:
- dependency-name: github.com/cometbft/cometbft
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix multiresolver for IPs

* lint

* enhance test

* lint
* use sync.cond for sign state signaling

* use existingSignatureOrErrorIfRegression

* handle feedback

* handle feedback

* last sign state initiated don't write to file

* final tidy
…s#170)

* threshold signer integration into local cosigner

* tidy
agouin and others added 26 commits July 31, 2023 10:24
* don't allow concurrent dials to same node

* remove timer, use timeout context only

* tidy

* feedback

* add timer for min amount of time between dial attempts
* Update goreleaser.yaml

* remove goreleaser

* perms
…ngelove-ventures#189)

Bumps [github.com/libp2p/go-libp2p](https://github.com/libp2p/go-libp2p) from 0.22.0 to 0.27.8.
- [Release notes](https://github.com/libp2p/go-libp2p/releases)
- [Changelog](https://github.com/libp2p/go-libp2p/blob/master/CHANGELOG.md)
- [Commits](libp2p/go-libp2p@v0.22.0...v0.27.8)

---
updated-dependencies:
- dependency-name: github.com/libp2p/go-libp2p
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix race in leader election test

* simplify
* fix go test

* add code of conduct

* Adds Contributing
* remote signer grpc server

* simplify api

* expose ToProto

* Go 1.21

* buf.lock perms

* Remove buf mod update

* direct path

* test updates

* Fix race in leader election test

* simplify

* Add test for horcrux proxy

* bump to go 1.21 in test too
* Pre-share nonces

* lint

* next cosigner retry

* improve

* fix test

* lint

* noplogger

* Add fallback to old nonces fetch mechanism

* lint

* use new raft get leader ID

* lint

* lint

* add back leader election timeout metric. Use existing grpc clients for ping

* error types

* Expired nonce pruning

* should use nonceExpiration

* make local cosigner nonce cache expiration twice the leader nonce cache
* FEAT: Add chain and node metris

* PATCH: Fix linting

* add drained nonce cache metrics

---------

Co-authored-by: gustavobelfort <[email protected]>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.9.0 to 0.17.0.
- [Commits](golang/net@v0.9.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…es#209)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.55.0 to 1.56.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.55.0...v1.56.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tures#206)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.11.0 to 0.17.0.
- [Commits](golang/net@v0.11.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ve-ventures#220)

* Bump github.com/ethereum/go-ethereum from 1.12.0 to 1.13.5

Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.12.0 to 1.13.5.
- [Release notes](https://github.com/ethereum/go-ethereum/releases)
- [Commits](ethereum/go-ethereum@v1.12.0...v1.13.5)

---
updated-dependencies:
- dependency-name: github.com/ethereum/go-ethereum
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* remaining dep bumps

* bump to sdk 50.1 and ibc-go v8

* bump raft

* bump all deps. lower raft timeout in tests

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Gouin <[email protected]>
* temp fix for error checking over rpc

* improve logs, lint

* use grpc status check instead of checking horcrux errs
* Account for continued nonce consumption in target. Sort by expiration

* remove redundant lock

* lock for entire GetNonces operation

* Swap map to slice for nonce cache in CosignerNonceCache

* Add tests, fix prune all

* Fix test

* Add Delete test

* lint

* siplify flaky test

* add comments
* Fix clearnonces index out of range

* Auto remove lockfile after unclean shutdown

* fix cmd
* Fine tune nonce consumption greater than get nonces interval

* lint

* fix test

* make tests less flakey

* fix test race
…test.go, threshold_signer_bls.go, and threshold_signer_soft.go
@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2023

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review.

34 files out of 107 files are above the max files limit of 50.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@nitronit
Copy link
Owner Author

@coderabbitai

@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2023

@nitronit

Absolutely, I'm here to help! Please provide the details or instructions, and we'll tackle them one by one.


💡 NOTE
The above message was generated in response to the following comment. Please use quote reply to maintain the context of the conversation.
@coderabbitai

@nitronit
Copy link
Owner Author

@nitronit

Absolutely, I'm here to help! Please provide the details or instructions, and we'll tackle them one by one.

💡 NOTE
The above message was generated in response to the following comment. Please use quote reply to maintain the context of the conversation.
@coderabbitai

@coderabbitai review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants