Skip to content

fix: allow no services #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyecusch merged 1 commit into from
Dec 30, 2024
Merged

fix: allow no services #837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions pkg/project/project.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ func (p *Project) GetBatchServices() []Batch {
func (p *Project) BuildBatches(fs afero.Fs, useBuilder bool) (chan ServiceBuildUpdate, error) {
updatesChan := make(chan ServiceBuildUpdate)

if len(p.services) == 0 {
return nil, fmt.Errorf("no services found in project, nothing to build. This may indicate misconfigured `match` patterns in your nitric.yaml file")
}

maxConcurrentBuilds := make(chan struct{}, min(goruntime.NumCPU(), goruntime.GOMAXPROCS(0)))

waitGroup := sync.WaitGroup{}
Expand Down Expand Up @@ -130,10 +126,6 @@ func (p *Project) BuildBatches(fs afero.Fs, useBuilder bool) (chan ServiceBuildU
func (p *Project) BuildServices(fs afero.Fs, useBuilder bool) (chan ServiceBuildUpdate, error) {
updatesChan := make(chan ServiceBuildUpdate)

if len(p.services) == 0 {
return nil, fmt.Errorf("no services found in project, nothing to build. This may indicate misconfigured `match` patterns in your nitric.yaml file")
}

maxConcurrentBuilds := make(chan struct{}, min(goruntime.NumCPU(), goruntime.GOMAXPROCS(0)))

waitGroup := sync.WaitGroup{}
Expand Down Expand Up @@ -573,6 +565,10 @@ func fromProjectConfiguration(projectConfig *ProjectConfiguration, localConfig *
return nil, fmt.Errorf("unable to match service files for pattern %s: %w", serviceMatch, err)
}

if len(files) == 0 {
return nil, fmt.Errorf("unable to match service files for pattern %s. This may indicate misconfigured `match` patterns in your nitric.yaml file", serviceMatch)
}

for _, f := range files {
relativeServiceEntrypointPath, _ := filepath.Rel(filepath.Join(projectConfig.Directory, baseService.GetBasedir()), f)
projectRelativeServiceFile := filepath.Join(projectConfig.Directory, f)
Expand Down
Loading