Skip to content

fix: ignore no status websocket error on local run #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjholm merged 3 commits into from
Jan 8, 2025
Merged

fix: ignore no status websocket error on local run #829

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d9e097
fix: remove erroring on websocket close reads
HomelessDinosaur Dec 16, 2024
5c97e02
fix: break loop on error
HomelessDinosaur Dec 16, 2024
0b57dfa
change to use error is notation
HomelessDinosaur Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/cloud/gateway/gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,11 @@ func (s *LocalGatewayService) handleWebsocketRequest(socketName string) func(ctx
// Need to create a unique ID for this connection and store in a central location
// This will allow connected clients to message eachother and broadcast to all clients as well
// We'll only read new messages on this connection here, writing will be done by a separate runtime API
// Won't print errors that arise if the socket is closed, i.e. "websocket: close 1005 (no status)"
_, message, err := ws.ReadMessage()
if err != nil {
if err != nil && strings.Contains(err.Error(), "no status") {
break
} else if err != nil {
log.Println("read:", err)
break
}
Expand Down