Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade dependencies #11

Merged
merged 3 commits into from
Mar 16, 2018
Merged

upgrade dependencies #11

merged 3 commits into from
Mar 16, 2018

Conversation

nampdn
Copy link
Contributor

@nampdn nampdn commented Mar 15, 2018

@nampdn
Copy link
Contributor Author

nampdn commented Mar 15, 2018

@nitin42 can you help me to fully upgrade this?

@nitin42
Copy link
Owner

nitin42 commented Mar 15, 2018

Awesome. Thanks for the PR. I've been busy lately with some other projects and it's getting very difficult for me to manage the time for this project. Anyway, I think we can fix the broken tests by installing the package canvas. Have you tried installing this package and then running all the tests again ?

@nitin42 nitin42 merged commit 21e7b64 into nitin42:master Mar 16, 2018
@nampdn
Copy link
Contributor Author

nampdn commented Mar 16, 2018

Thanks, @nitin42, I think the main point is canvas package but have not give it a try yet.
I love to help you to maintain this if it is your pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nampdn @nitin42