Working advanced anastasia#309
Open
Thanus31 wants to merge 14 commits into
Open
Conversation
Added a comment to the Hello World Workflow file.
5 tasks
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s GitHub Actions workflows as part of the “advanced” learning tasks (adding artifacts, job dependencies, and conditional execution) and includes small documentation updates.
Changes:
- Added new workflows (
custom.yml,conditional.yml) to demonstrate matrix builds, env vars, secrets, and conditional steps. - Updated the existing build/test workflow to upload/download an artifact and introduce a
needsdependency between jobs. - Minor README additions in the root and sample app docs; added a comment line in the hello-world workflow.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
sample-app/README.md |
Adds brief documentation lines near the end of the sample app README. |
README.md |
Appends a short learning-related line near the end of the root README. |
.github/workflows/hello-world.yml |
Adds an extra comment line near the top of the workflow. |
.github/workflows/custom.yml |
Introduces a new workflow demonstrating env vars, secrets, and a Node.js matrix. |
.github/workflows/conditional.yml |
Introduces a new workflow demonstrating a main-branch-only deploy step. |
.github/workflows/build-test.yml |
Reworks the build/test workflow to add artifact upload/download and a dependent job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,5 +1,7 @@ | |||
| name: Hello World Workflow | |||
|
|
|||
| #Thanus31 | |||
| branches: | ||
| - develop | ||
| - main | ||
| - working-advanced-anastasia |
| branches: | ||
| - develop | ||
| - main | ||
| - working-advanced-anastasia |
Comment on lines
+22
to
33
| - name: Setup Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: 'npm' | ||
| cache-dependency-path: 'sample-app/package-lock.json' | ||
|
|
||
| - name: Install dependencies | ||
| working-directory: ./sample-app | ||
| run: npm ci | ||
|
|
||
| - name: Run linter | ||
| working-directory: ./sample-app | ||
| run: npm run lint | ||
| continue-on-error: true | ||
|
|
||
| - name: Build application | ||
|
|
||
| - name: Install Dependencies | ||
| working-directory: ./sample-app | ||
| run: npm run build | ||
| - name: Run tests | ||
| run: npm install | ||
|
|
||
| - name: Run Tests | ||
| working-directory: ./sample-app | ||
| run: npm test |
Comment on lines
10
to
+13
| jobs: | ||
| build-and-test: | ||
| name: Build and Test | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [16.x, 18.x, 20.x] |
Comment on lines
+29
to
+31
| - name: Access Secret | ||
| env: | ||
| TEST_SECRET: ${{ secrets.TEST_SECRET }} |
Comment on lines
+35
to
+46
| - name: Setup Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
|
|
||
| - name: Install Dependencies | ||
| working-directory: ./sample-app | ||
| run: npm install | ||
|
|
||
| - name: Run Tests | ||
| working-directory: ./sample-app | ||
| run: npm test No newline at end of file |
| branches: | ||
| - develop | ||
| - main | ||
| - working-advanced-anastasia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes the completion of Advanced GitHub Actions learning tasks and workflow improvements.
Changes Made
needsFixes # (issue)
Type of Change
How Has This Been Tested?
The workflows were tested using GitHub Actions and verified through workflow logs and successful job execution.
Test Configuration
Checklist
Screenshots or Workflow Logs
Verified workflow runs successfully in the GitHub Actions tab.
Additional Context
This pull request was created as part of GitHub Actions Advanced Tasks practice and learning activities.