Preserve NumLock state in set_xkb_file#3576
Open
mgabor3141 wants to merge 1 commit intoniri-wm:mainfrom
Open
Conversation
set_keymap_from_string() creates a fresh XKB state, resetting all
locked modifiers. set_xkb_config() already saves and restores NumLock
around the keymap change, but set_xkb_file() did not.
This caused keyboard { numlock } to have no effect when combined with
xkb.file, since load_xkb_file() runs after numlock initialization at
startup. It also reset NumLock on config reload when the xkb section
changed.
Fixes niri-wm#3575
Sempyos
added
area:input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the NumLock save/restore pattern from
set_xkb_config()inset_xkb_file().set_keymap_from_string()creates a fresh XKB state, resetting all locked modifiers including NumLock.set_xkb_config()already handles this, butset_xkb_file()did not — sokeyboard { numlock }had no effect when combined withxkb.file.Fixes #3575