[Switch presets] add (no-)wraparound & make cycle-back an OPTION#3571
Open
two-horned wants to merge 3 commits intoniri-wm:mainfrom
Open
[Switch presets] add (no-)wraparound & make cycle-back an OPTION#3571two-horned wants to merge 3 commits intoniri-wm:mainfrom
two-horned wants to merge 3 commits intoniri-wm:mainfrom
Conversation
Contributor
Author
|
Important note: This will break configs using old Quick examples: |
Contributor
Sounds like a big no no for this to get merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves #1670 and adds a no-wraparound option which desire was mentioned at couple of places,
like in #1000 and #1367.
I didn't see the need to add tests, so if someone wants to contribute in that regard, please do so.