feat: Added recursion for binds config#3533
Open
spiros132 wants to merge 1 commit intoniri-wm:mainfrom
Open
Conversation
chore: Format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a feature regarding the binds config. It adds the ability for binds to have a more "organized" view as shown below. This PR still allows the normal way to create bindings, but also adds the recursive way.
When it comes to bind properties it follows the standard "OOP idea", for example if the parent has an allow-when-locked property, the child also follows the parent's allow-when-locked unless overridden.
If something looks weird, there is any bugs or anything could be changed to look better in the code, please do tell me!