-
Notifications
You must be signed in to change notification settings - Fork 5
REF: Generalize bvals and uptake value iterators into a single iterator #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
REF: Generalize bvals and uptake value iterators into a single iterator #303
Conversation
dddcb4d to
f916627
Compare
|
Sorry I cannot make heads or tails of the error:
We have not made changes to any components related to the transforms, The PR immediately preceding the failure succeeded with ITK 5.4.0: The only thing I can think of is some race condition deleting the file when the ANTs interface requires it. |
|
One thing that changes across failures is the name or iteration of the registration at which the test fails: e.g. in |
18e0493 to
8c72aef
Compare
Generalize bvals and uptake value iterators into a single iterator that is able to traverse the values in ascending or descending order depending on whether it is provided a list of b-values (DWI) or uptake values (PET). Follow-up to commit a1310e6.
8c72aef to
54931d6
Compare
Indeed, it looks like ANTs is on the same version. That's ver weird.
This makes sense if we are using the random iterator without a seed (which we are possibly doing?) We should fix a seed so that we iterate the dataset consistently across builds. If we are setting a seed, the seeding may not be properly working. |
The seed is fixed by the default value of the fixture. Have checked that the values of the data and iterator indices are the same across runs. |
Generalize bvals and uptake value iterators into a single iterator that is able to traverse the values in ascending or descending order depending on whether it is provided a list of b-values (DWI) or uptake values (PET).
Follow-up to commit a1310e6.
Fixes #230.