Skip to content

Conversation

@oesteban
Copy link
Member

@oesteban oesteban commented Oct 7, 2025

Test that latest nitransforms 25+ fixes the 4D resampling that was broken on 24.x

@oesteban oesteban force-pushed the maint/update-nitransforms-pin branch 2 times, most recently from 2a2badc to 14ffcd7 Compare October 7, 2025 11:25
@oesteban oesteban force-pushed the maint/update-nitransforms-pin branch 2 times, most recently from d0a1ae3 to 01700d1 Compare October 27, 2025 20:37
@jhlegarreta
Copy link
Contributor

jhlegarreta commented Oct 29, 2025

As for the typecheck failures I had tried locally:

  • Annotating the variables at issue, e.g.
    loa_lower: float = mean_diff - z_score * std_diff
    loa_upper: float = mean_diff + z_score * std_diff
    
  • Getting the items from the numpy arrays when returning:
    return (
        diff,
         mean,
         mean_diff.item(),
         std_diff.item(),
         loa_lower.item(),
         loa_upper.item(),
         ci_mean.item(),
         ci_loa.item(),
    )
    

None of the above worked, and I ran out of ideas. I do not see why casting should be necessary. So, the only way to silence warnings I found was to ignore them, i.e.

assert loa_lower < loa_upper  # type: ignore

@oesteban
Copy link
Member Author

Thanks for looking into it. Being a test I'd not worry anymore and silence it as you suggest

@jhlegarreta jhlegarreta force-pushed the maint/update-nitransforms-pin branch from 795dab3 to bce795c Compare November 2, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants