Expect flat bids_filters across package #110
Merged
+11
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109. We might need to overwrite these changes when we address #101.
It might also make it harder to fix #108.Actually I think I can fix #108 by using the bids_filters directly.Changes proposed in this pull request
bids_filters
to be a nested dictionary (e.g.,{"bold": {"acquisition": "good"}}
) to instead expect a flat dictionary that only applies to the BOLD data (e.g.,{"acquisition": "good"}
).