Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect flat bids_filters across package #110

Merged
merged 3 commits into from
Mar 12, 2025
Merged

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Mar 11, 2025

Closes #109. We might need to overwrite these changes when we address #101. It might also make it harder to fix #108. Actually I think I can fix #108 by using the bids_filters directly.

Changes proposed in this pull request

  • Reduce any cases that expect bids_filters to be a nested dictionary (e.g., {"bold": {"acquisition": "good"}}) to instead expect a flat dictionary that only applies to the BOLD data (e.g., {"acquisition": "good"}).

@tsalo tsalo added the bug Something isn't working label Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.84%. Comparing base (c3390c3) to head (a71b628).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/config.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   30.83%   30.84%   +0.01%     
==========================================
  Files          26       26              
  Lines        2374     2373       -1     
  Branches      289      288       -1     
==========================================
  Hits          732      732              
+ Misses       1619     1618       -1     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo tsalo merged commit 8a4a2a6 into main Mar 12, 2025
11 of 12 checks passed
@tsalo tsalo deleted the fix-config-filter-parsing branch March 12, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter parsing in config expects nested dictionary Filters only apply to base file
1 participant