BIDS filters are applied across queries

[tsalo]

What happened?

It looks like collect_derivatives is expecting a single filter dictionary (e.g., {'subject': ['01'], 'task': ['rest']}) to apply to all queries. However, we generally want filters to be specific to the file type being queried (e.g., {'bold_raw': {'task': ['rest']}, 'anat_mni152nlin6asym': {'reconstruction': 'norm'}}).

I am labeling this as a bug instead of a feature request because different file types have different entities that may apply, so (except for a couple of exceptions, like subject and session, that are handled internally by fMRIPost-AROMA) there aren't any "general" filters you'd want to apply across file types.

What command did you use?

n/a

What command did you use to run fMRIPrep?

What version of fMRIPost-AROMA are you running?

main as of a90f01f

How are you running fMRIPost-AROMA?

Other

Is your data BIDS valid?

Yes

Please copy and paste any relevant log output.

Additional information / screenshots

No response

[tsalo]

The annoying thing about the filter is that, if we want to apply filters independently to each file type, the filters end up being very long. I've noticed that in XCP-D (see PennLINC/xcp_d#1306 (comment)).

[tsalo]

With #102, we will use the filter dictionary on BOLD queries, but will only grab the "subject" and optionally "session" entities for anatomical queries. Maybe that's the best way forward- basically we let users control which BOLD files are collected, but not which anatomical files are used.