Skip to content

Update path for pc file installation #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Spritaro
Copy link

@Spritaro Spritaro commented Mar 22, 2025

This pull request updates the path for the pc file to ensure it is correctly installed from a subdirectory.

Currently, the install command installs the EIPScanner.pc file from CMAKE_BINARY_DIR. However, the configure_file command generates this file relative to CMAKE_CURRENT_BINARY_DIR. This causes cmake error during installation when the library is included in other projects via add_subdirectory.

To solve this, the install command has been modified to use CMAKE_CURRENT_BINARY_DIR instead of CMAKE_BINARY_DIR for the EIPScanner.pc file.

@Spritaro
Copy link
Author

Dear Maintainers,

Thank you so much for your awesome project! I just wanted to follow up on the PR that I submitted recently. I was wondering if anyone has had a chance to review it or if there's any additional information I can provide. For reference, it's related to #95.

Best regards,
Spritaro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant