-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#448] [Part2] sample yaml file for codemagic #489
[#448] [Part2] sample yaml file for codemagic #489
Conversation
Kover report for template-xml:🧛 Template - XML Unit Tests Code Coverage:
|
File | Coverage |
---|
Modified Files Not Found In Coverage Report:
README.md
Versions.kt
build.gradle.kts
build.gradle.kts
codemagic.yaml
codemagic.yaml
deploy_staging_and_production_to_firebase_app_distribution.yml
review_pull_request.yml
review_pull_request.yml
run_detekt_and_unit_tests.yml
run_detekt_and_unit_tests.yml
Codebase cunningly covered by count Shroud 🧛
Kover report for template-compose:
🧛 Template - Compose Unit Tests Code Coverage: 62.39%
Coverage of Modified Files:
File | Coverage |
---|
Modified Files Not Found In Coverage Report:
README.md
Versions.kt
build.gradle.kts
build.gradle.kts
codemagic.yaml
codemagic.yaml
deploy_staging_and_production_to_firebase_app_distribution.yml
review_pull_request.yml
review_pull_request.yml
run_detekt_and_unit_tests.yml
run_detekt_and_unit_tests.yml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
d709f2e
to
2841531
Compare
9b3950e
to
281fbb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good 👍
.cicdtemplate/.github/workflows/deploy_staging_and_production_to_firebase_app_distribution.yml
Outdated
Show resolved
Hide resolved
.cicdtemplate/.github/workflows/deploy_staging_and_production_to_firebase_app_distribution.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more issues related to what in .cicdtemplate, then it would be good @lydiasama 💪
.cicdtemplate/.github/workflows/deploy_staging_and_production_to_firebase_app_distribution.yml
Outdated
Show resolved
Hide resolved
@ryan-conway Let me keep the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files left need to be updated 🏃
What happened 👀
I'll split the task into 2 parts:
Part 1 :
template-compose
andtemplate-xml
whenopening PR
andPush
.Part 2 :
codemagic.yaml
file to.codemagic
directoryReadme.md
fileInsight 📝
We will have 2
codemagic.yaml
files:To access the Codemagic console:
[email protected]
signin from Github
No-Goes for template-xml
As we deprecated the
template-xml
, I didn't implement the deploy script fortemplate-xml
to Firebase.Github Environment Secrets and Variables setup
google-services.json
for production and staging are created at the Github environmenttemplate-compose
:Codemagic Environment
backup value to our template's Github environmentCodemagic environment
:Codemagic Environment Variables
Created the Codemagic Environment by the following:
Dynamic Version Code
For the dynamic version code, we have 2 alternatives to achieve:
Get the Codemagic's environment variable
BUILD_NUMBER
directly on thebuild.gragle
:And in the codemagic.yaml will be the simple build command:
versionCode
argument from the build command line:And in the codemagic.yaml will be the build command with
-PversionCode
argument:💡 Thus, from the pros and cons above, I selected option 2.
📖 The document about build versioning on Codemagic can be found here.
🙏🏻 Special Thanks: @AVI5HEK for helping me review the Codemagic environment setup.
Proof Of Work 📹
Production build:
Staging build: