Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Ubuntu 24.04 LTS #164

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Conversation

chrstnbwnkl
Copy link
Contributor

Fixes #163

@martbock
Copy link

martbock commented Sep 16, 2024

Thanks for the quick reaction 🙏

I took a peek in the base Dockerfile and noticed the Python base path changed. I got a working build with the following changes based on the recently changed lines in the valhalla/valhalla Dockerfile:

  ...

- FROM ubuntu:23.04 as runner_base
+ FROM ubuntu:24.04 as runner_base
  MAINTAINER Nils Nolde <[email protected]>

  RUN apt-get update > /dev/null && \
    export DEBIAN_FRONTEND=noninteractive && \
-   apt-get install -y libluajit-5.1-2 libgdal32 \
+   apt-get install -y libcurl4 libczmq4 libluajit-5.1-2 libgdal34 \
    libzmq5 libczmq4 spatialite-bin libprotobuf-lite32 sudo locales \
    libsqlite3-0 libsqlite3-mod-spatialite libcurl4 \
-   python3.11-minimal python3-distutils curl unzip moreutils jq spatialite-bin python-is-python3 > /dev/null
+   curl gdb locales parallel python3-minimal python-is-python3 python3-shapely python3-requests \
+   unzip moreutils jq \
+   > /dev/null

  COPY --from=builder /usr/local /usr/local
- COPY --from=builder /usr/lib/python3/dist-packages/valhalla/* /usr/lib/python3/dist-packages/valhalla/
+ COPY --from=builder /usr/local/lib/python3.12/dist-packages/valhalla /usr/local/lib/python3.12/dist-packages/

  ...

Note that I might have copied over more apt packages than what is actually required, but I didn't have time to check which of the individual packages was missing before. I'm guessing you know that better than me anyways 😇

@chrstnbwnkl chrstnbwnkl changed the title Avoid wildcard operator when copying Update to Ubuntu 24.04 LTS Sep 16, 2024
@chrstnbwnkl
Copy link
Contributor Author

Yeah I realized it was probably the upstream base image's upgrade to 24.04, but didn't have the time this weekend to make all the required changes. Thanks for the pointers!

@chrstnbwnkl chrstnbwnkl merged commit 78e9259 into master Sep 16, 2024
1 check passed
@chrstnbwnkl chrstnbwnkl deleted the cb-remove-wildcard-from-copy branch September 16, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build fails: lstat Python valhalla packages not found
2 participants