Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for commands #4

Closed
wants to merge 1 commit into from

Conversation

Architeuthis-Flux
Copy link
Contributor

Turns out both the Jumperless firmware was dropping characters from the commands because it wasn't waiting long enough between reading each character to the input buffer. Also jlctl was timing out because it wasn't waiting long enough.

But between the new firmware and this change, it's pretty rock solid.

Check it out
https://github.com/nilclass/jlctl/assets/20519442/b12b3518-45ae-4ce1-b05e-c913b243174f

I also added validation for the special functions on the Nano header, it still needs to somehow recognize them as actual rails and add them to the right special net, but at least it doesn't return HTTP BAD REQUEST and not update the rest of the connections in Jumperlab. There are a bunch of ways to fix that, but I'll let you decide what makes the most sense for jlctl.

@nilclass
Copy link
Owner

nilclass commented Feb 1, 2024

Great job, looks like increasing the timeout fixes the issue.
I applied that change manually just now in b4f85f7, since I'm not convinced yet that supporting the nano names (n3v3, ngnd0, etc) on the API level is a good idea. I'm worried it will lead to the UI and the board disagreeing which nodes are the same and which aren't.
As an alternative, I pushed a change to jumperlab, so those nodes are sent as "GND", "SUPPLY_5V" etc. from jumperlab (and also another change to show correct colors):
image

let me know if that works for you

@Architeuthis-Flux
Copy link
Contributor Author

Ha that's exactly what I was trying to make happen but couldn't figure out how to do it. Which is great because they'll be added to the correct net.

I really should just be pushing PRs with arrows being like "the issue is probably right here but I'll write some hacky code in 3 hours and you'll fix it properly in like 5 seconds."

Also, in that picture, have you figured out what's causing the rails to be white sometimes?

Anyway, I'm working on getting this setup packaged as an app so other people can find bugs too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants