PEP 492 - Rename async #54
Conversation
|
@nikipore Is this what you were looking for in a PR? |
|
Yes it is, thank you. I am way too busy right now (job and kids), plus I am going to be on vacation, so a proper test and package before end-of-year might be a problem. This is a backwards-incompatible change, so I am going to bump the release to 2.4. Time that someone else takes over this project, it has no longer relevance for my daily work, although I am still at the same company (but have moved on to other missions and no longer program myself on the job). |
| 0. I still do accept (and test) pull requests and bugfixes (if they come with complete and working unit and integration tests), but the Python 3 port was my last big effort for stompest. | ||
| 1. I believe that fully implementing the (half-complete) SSL/TLS capability is the most urgent enhancement because apart of that I consider stompest pretty much feature complete and very stable up to Python 3.6; the rate of newly discovered bugs is very low indeed. | ||
| 2. For Python 3.7, the `stompest.async` package must be renamed; I believe `stompest.twisted` would be appropriate. If someone creates a pull request, I'll test it and rename the PyPI package accordingly. | ||
| 2. For Python 3.7, the `stompest.twisted` package must be renamed; I believe `stompest.twisted` would be appropriate. If someone creates a pull request, I'll test it and rename the PyPI package accordingly. |
|
@nikipore were you able to get sometime to merge this request? Seems good to me |
|
I'm also interested in getting this to work, STOMP libraries for Python are kinda scarce. |
|
Sorry guys, I am entirely immersed in job and family. Don't know when or whether I'll find the time to adopt this. Problem is, I've got to set up everything from scratch, and this will be a breaking change, meaning that I will probably have to deprecate the PyPI package Still no-one interested in taking over and starting a new fork? I'd be willing to pass the control of the PyPI packages. This is how I got hooked by @theduderog years ago ... |
5 participants
This will rename all module references of
asynctotwistedto be compatible with Python 3.7+.I ran the tests but I think the SSL ones failed. Please run your own tests before merging.
Resolves #46