-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Python 3.13 support #61
Conversation
Reviewer's Guide by SourceryThis PR updates the GitHub Actions workflow to support Python 3.13 and upgrades several GitHub Actions to their latest versions. The implementation involves modifying the test matrix configuration and updating action versions in the workflow file. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nikhilbadyal - I've reviewed your changes - here's some feedback:
Overall Comments:
- Note that Python 3.13 is currently in alpha stage and won't be released until October 2024. Consider whether testing against a development version is necessary at this stage, as it may lead to unstable test results.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 338 338
=========================================
Hits 338 338 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
CI: