Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Python 3.13 support #61

Merged
merged 1 commit into from
Dec 7, 2024
Merged

⬆️ Python 3.13 support #61

merged 1 commit into from
Dec 7, 2024

Conversation

nikhilbadyal
Copy link
Owner

@nikhilbadyal nikhilbadyal commented Dec 7, 2024

Summary by Sourcery

CI:

  • Add Python 3.13 to the testing matrix in the GitHub Actions workflow.

@nikhilbadyal nikhilbadyal added ci/cd👷 CI/CD Tasks chore🧹 Code Cleanup dependencies🫂 Updated dependencies labels Dec 7, 2024
@nikhilbadyal nikhilbadyal self-assigned this Dec 7, 2024
Copy link

sourcery-ai bot commented Dec 7, 2024

Reviewer's Guide by Sourcery

This PR updates the GitHub Actions workflow to support Python 3.13 and upgrades several GitHub Actions to their latest versions. The implementation involves modifying the test matrix configuration and updating action versions in the workflow file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Python 3.13 support to the test matrix
  • Added Python 3.13 as a new test environment configuration
.github/workflows/pytest.yml
Updated GitHub Actions to their latest versions
  • Updated actions/checkout from v4.1.7 to v4.2.2
  • Updated actions/setup-python from v5.1.1 to v5.3.0
  • Updated codecov/test-results-action from v1.0.0 to v1.0.1
.github/workflows/pytest.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nikhilbadyal - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Note that Python 3.13 is currently in alpha stage and won't be released until October 2024. Consider whether testing against a development version is necessary at this stage, as it may lead to unstable test results.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9791b3f) to head (d03326b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          338       338           
=========================================
  Hits           338       338           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikhilbadyal nikhilbadyal merged commit 11789e3 into main Dec 7, 2024
10 checks passed
@nikhilbadyal nikhilbadyal deleted the python3.13 branch December 7, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore🧹 Code Cleanup ci/cd👷 CI/CD Tasks dependencies🫂 Updated dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant