-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Updated pre-commit config and dependencies-update #60
Conversation
Reviewer's Guide by SourceryThis PR updates the project's pre-commit configuration and dependencies. The main changes include simplifying the pre-commit hooks by removing pycln and docformatter, updating package versions in requirements.txt, and making minor documentation improvements. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nikhilbadyal - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you explain the rationale for removing the pycln and docformatter pre-commit hooks? These tools help maintain code quality and documentation consistency.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 338 338
=========================================
Hits 338 338 ☔ View full report in Codecov by Sentry. |
a890754
to
3e49fe3
Compare
3e49fe3
to
6b844f7
Compare
Summary by Sourcery
Update pre-commit configuration and dependencies, remove unused hooks, and clarify README description.
Build:
Documentation:
Chores: