-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow the cli to be imported as module #55
Conversation
Reviewer's Guide by SourceryThis pull request modifies the esxport package to allow it to be imported as a module. The changes include restructuring imports, modifying the EsXport class initialization, updating the CLI implementation, and adjusting test fixtures. The main goal is to improve the package's modularity and make it easier to use as a library. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nikhilbadyal - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
39d5eeb
to
2ea87a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 318 325 +7
=========================================
+ Hits 318 325 +7 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Allow the CLI to be imported as a module by refactoring the EsXport class to handle ElasticsearchClient instantiation internally and updating import statements to use relative paths. Adjust test fixtures to accommodate these changes.
Enhancements:
Tests: