Skip to content

Check format of configured jscpd version #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhaldi merged 1 commit into from
Apr 13, 2026
Merged

Check format of configured jscpd version #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions servers/jscpd.js
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions src/lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ export function buildArgs(config, toolArgs) {
return args;
}

const VERSION_RE = /^\d+\.\d+\.\d+(-[\w.]+)?$/;

export function runJscpd(version, args) {
if (!VERSION_RE.test(version)) {
throw new Error(`Invalid jscpd version: "${version}"`);
}
const fullArgs = [`jscpd@${version}`, ...args];
const cmd = ["npx", ...fullArgs];
return new Promise((resolve, reject) => {
Expand Down
15 changes: 15 additions & 0 deletions test/lib.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import assert from "node:assert/strict";
import {
camelToKebab,
buildArgs,
runJscpd,
parseReport,
REPORT_DIR,
DRYWALL_KEYS,
Expand Down Expand Up @@ -301,3 +302,17 @@ describe("parseReport", () => {
assert.ok(result.duplicates[0].fragment.length < 200);
});
});

describe("runJscpd", () => {
it("rejects invalid version strings", () => {
assert.throws(
() => runJscpd("../../malicious-pkg", []),
/Invalid jscpd version/,
);
assert.throws(() => runJscpd("jscpd@evil", []), /Invalid jscpd version/);
assert.throws(
() => runJscpd("1.0.0; rm -rf /", []),
/Invalid jscpd version/,
);
});
});
Loading