Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds batch generation capability to the z-image-ncnn-vulkan tool, allowing users to generate multiple images in a single run with different random seeds. The implementation processes images sequentially using a single model load, where each image in the batch gets a unique seed (seed + batch_index).
Changes:
- Added
-b batch-sizecommand-line option with validation (must be > 0) - Modified image generation to use a vector of latents instead of a single latent
- Restructured the main loop to process each batch item sequentially
- Implemented automatic filename generation for batch mode (filename-0.ext, filename-1.ext, etc.)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/main.cpp | Added batch processing logic, CLI argument parsing for batch size, latent vector handling, and batch-aware progress messages and file naming |
| README.md | Updated usage documentation to include the new -b batch-size option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.