Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data cleanings + sharpe ratio #4

Merged
merged 2 commits into from
Feb 11, 2020
Merged

data cleanings + sharpe ratio #4

merged 2 commits into from
Feb 11, 2020

Conversation

kitas91
Copy link
Collaborator

@kitas91 kitas91 commented Feb 11, 2020

No description provided.

@kitas91 kitas91 closed this Feb 11, 2020
kitas91
kitas91 commented Feb 11, 2020
View reviewed changes
Copy link
Collaborator Author

@kitas91 kitas91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to change daily to monthly data.
Separated the data gathering + cleaning from sharpe ratio.
saved to clipboard so we can pull the monthly data in via csv Path for future jupyter notebooks

@kitas91 kitas91 reopened this Feb 11, 2020
@nicolegoldin nicolegoldin merged commit 1e03518 into master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolegoldin nicolegoldin nicolegoldin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitas91 @nicolegoldin