guard process creation with a mutex

Fixes an fd leak on all unix systems that don't have pipe2.
As of today, that's all unix systems that are not dragonfly bsd,
freebsd, linux, netbsd, openbsd, or redox -- in particular, macOS.

Fixes evmar#14.

Cargo.toml

@@ -9,6 +9,7 @@ edition = "2018"
 getopts = "0.2"
 anyhow = "1.0"
 libc = "0.2"
+lazy_static = "1.4.0"
 
 [target.'cfg(windows)'.dependencies]
 kernel32-sys = "0.2.2"

src/lib.rs

@@ -13,6 +13,9 @@ mod task;
 pub mod trace;
 pub mod work;
 
+#[macro_use]
+extern crate lazy_static;
+
 #[cfg(not(target_env = "msvc"))]
 use jemallocator::Jemalloc;
 

src/task.rs

@@ -18,6 +18,9 @@ use std::io::Write;
 #[cfg(unix)]
 use std::os::unix::process::ExitStatusExt;
 
+#[cfg(unix)]
+use std::sync::Mutex;
+
 #[cfg(windows)]
 extern crate winapi;
 
@@ -83,12 +86,24 @@ fn run_task(
     Ok(result)
 }
 
+#[cfg(unix)]
+lazy_static! {
+    static ref TASK_MUTEX: Mutex<i32> = Mutex::new(0);
+}
+
 #[cfg(unix)]
 fn run_command(cmdline: &str) -> anyhow::Result<TaskResult> {
-    let mut cmd = std::process::Command::new("/bin/sh")
+    // Command::spawn() can leak FSs when run concurrently, see #14.
+    let just_one = TASK_MUTEX.lock().unwrap();
+    let p = std::process::Command::new("/bin/sh")
         .arg("-c")
         .arg(cmdline)
-        .output()?;
+        .stdout(std::process::Stdio::piped())
+        .stderr(std::process::Stdio::piped())
+        .spawn()?;
+    drop(just_one);
+
+    let mut cmd = p.wait_with_output()?;
     let mut output = Vec::new();
     output.append(&mut cmd.stdout);
     output.append(&mut cmd.stderr);

tests/basic.rs

@@ -26,7 +26,7 @@ fn print_output(out: &std::process::Output) {
 fn assert_output_contains(out: &std::process::Output, text: &str) {
     let out = std::str::from_utf8(&out.stdout).unwrap();
     if !out.contains(text) {
-        panic!("assertion failed; expected output to contain {:?}", text);
+        panic!("assertion failed; expected output to contain {:?} but got {}", text, out);
     }
 }